Bug 133613 - OpenPBS-2.3.16-611: two buglets
Summary: OpenPBS-2.3.16-611: two buglets
Status: RESOLVED FIXED
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: Final
Hardware: All SuSE Linux 10.0
: P5 - None : Minor
Target Milestone: ---
Assignee: Marcus Rückert
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-13 17:17 UTC by David Binderman
Modified: 2006-02-07 15:21 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2005-11-13 17:17:52 UTC 
I just tried to compile package OpenPBS-2.3.16-611 with a prerelease of the
GNU C compiler version 4.1

It said

1.

accounting.c:361: warning: "pblen" is used uninitialized in this function

The source code is

	pbs_strncat(pb, lilbuff, pblen);

I have checked the source code, and I agree with the compiler. 
Suggest initialise local variable "pblen" before first use.

2.

mom_comm.c:2997: warning: "reply" is used uninitialized in this function

The source code is

	if (reply) {

I've had a look at the source code, and I'm not sure that the compiler is
correct. Suggest initialise local variable "reply" at it's declaration
to shut up the compiler.
Comment 1 Marcus Rückert 2006-02-07 15:21:30 UTC 
those warnings dont happen in factory anymore, which uses gcc 4.1 aswell.