Bug 133759 - openCryptoki-2.1.5-8: printf problems
Summary: openCryptoki-2.1.5-8: printf problems
Status: RESOLVED FIXED
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: Final
Hardware: All SuSE Linux 10.0
: P5 - None : Minor
Target Milestone: ---
Assignee: Hannes Reinecke
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-14 21:34 UTC by David Binderman
Modified: 2006-03-09 14:44 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2005-11-14 21:34:10 UTC 
I just tried to compile package openCryptoki-2.1.5-8 with the Intel C compiler.

It said

no_odm.c(759): warning #267: the format string requires additional arguments

The source code is

            fprintf(stderr, "\nReading Slot Info: %s: looking at %s, stat64() returned %s (%d; %#x)", sinfo_struct.dll_location, SysError(Err), Err, Err);

Five %specifiers, only four trailing parameters.
Suggest code rework.
Comment 1 Hannes Reinecke 2006-03-09 12:01:54 UTC 
You're welcome to try. I already fixed tons of likewise errors just to get it compiled with gcc.
Blame the upstream maintainer.
Comment 2 David Binderman 2006-03-09 12:38:35 UTC 
(In reply to comment #1)
> You're welcome to try. 

This has always been true. 

> I already fixed tons of likewise errors just to get it compiled with gcc.

I would like to confirm with you that you are happy for
this known broken line of code to form part of the Suse 10.1 release
and that you are refusing to fix it.

> Blame the upstream maintainer.

I think allocating blame will not help solve the problem.
Comment 3 Hannes Reinecke 2006-03-09 14:44:48 UTC 
It's just that we most likely won't be fixing this problem for 10.0.

For 10.1 Beta6 eg. it is already fixed. And the code quality _is_ bad.
But this is nothing we will or can fix here locally, this has to be fixed upstream.