Bug 133904 - pvm-3.4.5-6: printf problems
Summary: pvm-3.4.5-6: printf problems
Status: RESOLVED FIXED
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: Final
Hardware: All SuSE Linux 10.0
: P5 - None : Minor
Target Milestone: ---
Assignee: Marcus Rückert
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-15 20:08 UTC by David Binderman
Modified: 2006-03-22 17:36 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2005-11-15 20:08:08 UTC 
I just tried to compile package pvm-3.4.5-6 with the Intel C 
compiler.

It said

../../src/pvmlog.c(491): warning #267: the format string requires additional arguments

The source code is

	pvmlogprintf("[%x/%c]", em[i]);

Two %specifiers, only one trailing parameter.

Suggest code rework. 

BTW, the email address of the author [ pvm@msr.epm.ornl.gov ] appears 
to be broken.
Comment 1 Marcus Rückert 2006-01-23 20:54:36 UTC 
i dont have this error anymore. and i fixed tons of other warnings.
Comment 2 David Binderman 2006-03-22 12:01:13 UTC 
(In reply to comment #1)
> i dont have this error anymore. and i fixed tons of other warnings.

I said Intel C compiler, not GNU GCC compiler.

The warning is still there in the version of 22 March 2006.
Comment 3 Marcus Rückert 2006-03-22 14:19:49 UTC 
thats the best solution i could think of. best way would be reporting this to upstream aswell.

[[[
$ cat pvm-3.4.5_missing_format_param.patch
Index: src/pvmlog.c
===================================================================
--- src/pvmlog.c.orig
+++ src/pvmlog.c
@@ -488,7 +488,7 @@
        pvmlogprintf("em=0x%lx\n", (long) em);
 
        for (i=0; i < 10 ; i++ )
-               pvmlogprintf("[%x/%c]", em[i]);
+               pvmlogprintf("[%x/%c]", em[i], em[i]);
        pvmlogprintf("\n");
 
        pvmlogprintf("%s: %s\n", s, em);
]]]
Comment 4 Marcus Rückert 2006-03-22 17:36:26 UTC 
closing as of last comment.