Bug 134187 - NetworkManager segfault if DBUS stopped
Summary: NetworkManager segfault if DBUS stopped
Status: VERIFIED FIXED
: 134179 (view as bug list)
Alias: None
Product: SUSE Linux 10.1
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: Alpha 3
Hardware: Other Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Timo Hoenig
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-17 15:11 UTC by Danny Al-Gaaf
Modified: 2007-06-05 09:57 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
strace from segfault (7.15 KB, application/octet-stream)
2005-11-17 15:11 UTC, Danny Al-Gaaf
Details
Backtrace from crash. Segfault is in libdbus. (626 bytes, text/plain)
2005-12-08 18:10 UTC, Robert Love
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Danny Al-Gaaf 2005-11-17 15:11:16 UTC
If you stop DBUS you get a segfault of the Networkmanager. This is IMO not the same problem as if you stop HAL daemon. Because this happen also if do this:

* rcnetworkmanager stop
* rchal stop
* rcnetworkmanager start
* rcdbus stop --> segfault

I attach a strace ;-)
Comment 1 Danny Al-Gaaf 2005-11-17 15:11:54 UTC
Created attachment 57650 [details]
strace from segfault
Comment 2 Robert Love 2005-11-17 19:47:42 UTC
The current view of DBUS hackers is that DBUS should not be restarted on a live system.

http://mail.gnome.org/archives/networkmanager-list/2005-March/msg00023.html
http://mail.gnome.org/archives/networkmanager-list/2005-March/msg00029.html

It is a sensible argument.  But we can do better than crash, to be sure.
Comment 3 Danny Al-Gaaf 2005-11-18 13:10:15 UTC
Yes I know this discussion, and I can't agree to the arguments. IMO there must/should be a way to restart DBUS. To reboot after a update is for me a really stupid idea (for me the only acceptable reason for a reboot is a kernel-update or a kernel oops but not a update of a system daemon), but this is not the point in this bug ;)
Comment 4 Seth R Arnold 2005-12-01 20:11:34 UTC
(In reply to comment #2)
> The current view of DBUS hackers is that DBUS should not be restarted on a live
> system.

DBUS might be linked against libraries that are upgraded by whatever will replace yast online update (say, for security updates). Requiring a reboot just to run against new libraries seems a bit harsh to me.
Comment 5 Robert Love 2005-12-01 20:13:56 UTC
The plan is for DBUS to be ABI/API compatible once it reaches 1.0, so that won't be a concern.
Comment 6 Robert Love 2005-12-08 18:05:00 UTC
*** Bug 134179 has been marked as a duplicate of this bug. ***
Comment 7 Robert Love 2005-12-08 18:09:32 UTC
Alright.  I did some work in NM to make it a little more resiliant to DBUS problems.  There is still a segfault, however: Now, in libdbus.  libdbus itself segfaults when used on a no-longer-valid connection.  See backtrace.

Reassigning to DBUS maintainer, as the problem is in libdbus.  But, as Kay says, "supporting DBUS restarts is like expecting X applications to survive an X restart"  ;-)
Comment 8 Robert Love 2005-12-08 18:10:08 UTC
Created attachment 60126 [details]
Backtrace from crash.  Segfault is in libdbus.
Comment 9 Timo Hoenig 2005-12-08 18:24:41 UTC
I'll have a look.
Comment 10 Danny Al-Gaaf 2005-12-08 20:57:54 UTC
(In reply to comment #7)
> But, as Kay says, "supporting DBUS restarts is like expecting X applications 
> to survive an X restart"  ;-)

IMO this is complete wrong position. There are many programms which survive a DBUS restart as e.g. HAL, powersave, KPowersave ... 

This should work. Everything other is a alibi ;-)

Comment 11 Robert Love 2006-03-03 17:40:10 UTC
This should now be fixed.  Right, Timo?
Comment 12 Timo Hoenig 2006-03-03 18:00:23 UTC
Yes, that's done.  Thus, closing as fixed.