Bugzilla – Bug 134417
simias-1.1.5242.1-4: returning garbage to caller
Last modified: 2011-10-11 07:09:32 UTC
I just tried to compile package simias-1.1.5242.1-4 with the Intel C compiler. It said 1. simias-event-client.c(407): warning #1011: missing return statement at end of non-void function "sec_cleanup" simias-event-client.c(958): warning #1011: missing return statement at end of non-void function "sec_proc_msg_thread" simias-event-client.c(890): warning #1011: missing return statement at end of non-void function "sec_reg_thread" simias-event-client.c(782): warning #1011: missing return statement at end of non-void function "sec_thread" Suggest add return statements. 2. simias-event-client.c(807): warning #117: non-void function "sec_reg_thread" should return a value The source code is if (ec->state == CLIENT_STATE_SHUTDOWN) { return; } Suggest change return statement to return NULL;
Mike is this your area of expertise?
This is Boyd's area.
You are using an Intel compiler in linux? We support GCC version 4. Please recompile with GCC4.
(In reply to comment #3) > You are using an Intel compiler in linux? Yes. >We support GCC version 4. True, but irrelevant ? >Please recompile with GCC4. Recompiling with gcc4 would just ignore the problem. The simias source code appears to be broken. I recommend fixing it.
I just realized that I need to read these bug reports more closely. I got into "the zone" of clearing out as many as possible. Thanks for catching this. I've fixed up the return statements as you've suggested (into the 3.4 branch and svn trunk).