Bug 134587 - ted-2.17-2: dodgy code
Summary: ted-2.17-2: dodgy code
Status: RESOLVED FIXED
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: Final
Hardware: All SuSE Linux 10.0
: P5 - None : Minor
Target Milestone: ---
Assignee: Ladislav Michnovic
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-20 18:33 UTC by David Binderman
Modified: 2005-11-30 17:25 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2005-11-20 18:33:20 UTC 
Hello there,

I just tried to compile package ted-2.17-2 with the GNU C compiler.

It said

appTree.c:359: warning: comparisons like X<=Y<=Z do not have their mathematical meaning

The source code is

    if  ( ( ! tn->tnParent || tn->tnIsOpen )    &&
          tn->tnChildCount > 0                  > 0 )

Suggest code rework.


Regards

David Binderman
Comment 1 Ladislav Michnovic 2005-11-21 18:22:35 UTC 
I'm working on it.
Comment 2 Ladislav Michnovic 2005-11-30 17:25:49 UTC 
Code reworked.