Bug 136622 - false sense of security: root allowed, lock screen displayed in menu
Summary: false sense of security: root allowed, lock screen displayed in menu
Status: RESOLVED FIXED
: 179800 187660 200820 204100 207341 217187 263268 (view as bug list)
Alias: None
Product: openSUSE 11.0
Classification: openSUSE
Component: GNOME (show other bugs)
Version: Alpha 2
Hardware: Other SLED 10
: P5 - None : Major (vote)
Target Milestone: ---
Assignee: Scott Reeves
QA Contact: E-mail List
URL:
Whiteboard: gnome-function-does-not-work
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-02 03:06 UTC by S. Handgraaf
Modified: 2008-02-05 23:25 UTC (History)
6 users (show)

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description S. Handgraaf 2005-12-02 03:06:05 UTC
I don't know why it is allowed to login as root to the gui, but it is very strange the user is then shown the menu option to lock screen by default. Imho this gives a false sense of security since root can never lock the screen with this and is also not very user friendly since the user is given an option that does not work without any notice saying so.

If a user is allowed to log in to the gui as root, only menu options that will function should be shown or at least warnings should be displayed when root tries to use such options.
Comment 1 JP Rosevear 2005-12-07 13:30:30 UTC
That seems true, locking as root does not work.
Comment 2 Rodrigo Moya 2006-01-19 18:52:54 UTC
Locking as root does not work on purpose, because of this: http://live.gnome.org/GnomeScreensaver_2fFrequentlyAskedQuestions

That is, the same reason xscreensaver did the same.
Comment 3 S. Handgraaf 2006-03-16 08:03:59 UTC
Yes, it is on purpose locking does not work. That is not the problem and confirmation here is not a solution for the user on the system.

Again, if a user is allowed to log in to the gui as root, only menu options that will function should be shown or at least warnings should be displayed when root
tries to use such options.
Comment 4 Rodrigo Moya 2006-03-16 13:48:46 UTC
The user on the system should not use root at all. So yeah, probably we want to disable things in the GUI for power users that while being power still forget using X with root is dangerous.

So, marking as enhancement
Comment 5 S. Handgraaf 2006-05-27 00:38:29 UTC
Is it prefered to call this not an enhancement but a bug since it is security related and other warnings are already on the system for functions not working for root users in the gui mode?

Example: Beagle already warns root users the function is realy disabled and closes itselve to make it clear it does not work for root and thus can not be used.

The Gnome Desktop "lock screen" function for root users does not give any warning about security risks, but still blanks the screen. This gives the impression the lock function has to work and also does work. Untill the user finds out the hard way the blanked screen was not locked...
Comment 6 Rodrigo Moya 2006-05-27 20:03:48 UTC
Yeah, maybe we should display that warning dialog. Anna? JP?
Comment 7 JP Rosevear 2006-05-28 17:26:50 UTC
Rodrigo, talk to the upstream maintainer and see what he thinks first.

We could add an english only dialog or message (not to bad since root defaults to english even if another language is selected as primary in yast2).
Comment 8 Rodrigo Moya 2006-05-30 12:01:03 UTC
*** Bug 179800 has been marked as a duplicate of this bug. ***
Comment 9 JP Rosevear 2006-05-30 13:33:25 UTC
Raising to major while we review this.

Security team, can you weigh in on this?
Comment 10 Ludwig Nussel 2006-05-30 14:15:07 UTC
the arguments why xscreensaver (http://www.jwz.org/xscreensaver/faq.html#root-lock) doesn't work as root sound bogus to me. Using nobody as unprivileged user for this purpose is wrong anyways. xlock works as root btw.
the pam config for screensavers doesn't include pam_rootok.so therefore the behavior to not lock is hardcoded at an unexpected place.

So I'd consider this behavior a bug in the screensaver. Certainly not a major one though. No need to fix this in already released distros.

Wrt false sense of security: *shrug* just move your mouse and you'll see that it didn't lock. Don't log in as root in the first place.

Anyways, the gnome desktop team should consider using the same nice background for the root user as the KDE desktop. It make it pretty obvious that logging in as root is no good idea without actually displaying any annoying warnings.
Comment 11 Rodrigo Moya 2006-05-31 08:40:46 UTC
does kdm do anything when the user authenticates as root? (like showing a message) I guess we could use that background in GNOME also.
Comment 12 Ludwig Nussel 2006-05-31 08:57:10 UTC
No it doesn't show any message. It does not offer root in the user list though so there is nothing that encourages logging in as root at all.
Comment 13 S. Handgraaf 2006-05-31 11:53:00 UTC
(In reply to comment #10)
> Wrt false sense of security: *shrug* just move your mouse and you'll see that
> it didn't lock. Don't log in as root in the first place.

Security is not only for people who don't make mistakes or just don't have enough knowledge.

> Anyways, the gnome desktop team should consider using the same nice background
> for the root user as the KDE desktop. It make it pretty obvious that logging
> in as root is no good idea without actually displaying any annoying warnings.
> 

The same unexpected place to code security measures as the current design. It is more secure to place a warning in the screensaver behaviour then to create preventive measures outside it on the desktop. It only takes one nice designer to mangle the screensaver security but a lot of greatfull users to disable a warning option if they don't like it.
Comment 14 Rodrigo Moya 2006-06-06 15:07:21 UTC
One thing we could do is to not show the Lock Screen menu item when running as root. We'd need to patch gnome-panel and gnome-main-menu. JP, Anna, should we do that?
Comment 15 JP Rosevear 2006-06-22 23:29:46 UTC
*** Bug 187660 has been marked as a duplicate of this bug. ***
Comment 17 S. Handgraaf 2006-08-18 02:16:31 UTC
(In reply to comment #14)
> One thing we could do is to not show the Lock Screen menu item when running as
> root. We'd need to patch gnome-panel and gnome-main-menu. JP, Anna, should we
> do that?
> 

I sugest to do so since it all starts with this dangerous menu item. Hope JP and Anna find time for a reply on this question.
Comment 18 Rodrigo Moya 2006-08-22 11:03:25 UTC
*** Bug 200820 has been marked as a duplicate of this bug. ***
Comment 19 Rodrigo Moya 2006-09-07 14:56:29 UTC
*** Bug 204100 has been marked as a duplicate of this bug. ***
Comment 20 Mark Gordon 2006-09-21 14:28:00 UTC
*** Bug 207341 has been marked as a duplicate of this bug. ***
Comment 21 Marcus Meissner 2006-09-21 14:34:17 UTC
i dont really know.

customers seem to expect it ... 

so its a pretty bad user experience, dont you think?
Comment 22 Mark Gordon 2006-11-01 22:25:28 UTC
*** Bug 217187 has been marked as a duplicate of this bug. ***
Comment 23 JP Rosevear 2007-01-26 17:19:34 UTC
Rodrigo, can you talk to William upstream about why this is done?  I think there are a sufficient number of duplicates to warrant doing this if its not 100% correct.
Comment 24 Magnus Boman 2007-04-16 11:24:55 UTC
*** Bug 263268 has been marked as a duplicate of this bug. ***
Comment 25 Magnus Boman 2007-04-16 11:27:10 UTC
Ok, so this is still an issue in GNOME 2.18... If we can't get any answers from upstream (comment#23), can we create out own patch for it and lock the screen?
Comment 26 Thomas Biege 2007-05-21 12:39:36 UTC
Any news?
Comment 28 Ray Dassen 2007-07-11 15:07:54 UTC
The FAQ referenced in comment #2 can be found as
	http://live.gnome.org/GnomeScreensaver/FrequentlyAskedQuestions
nowadays.
Comment 29 S. Handgraaf 2007-10-01 09:22:39 UTC
I hope Rodrigo can find time to answer the question in comment #23 by now.
Comment 30 Rodrigo Moya 2007-10-01 17:33:55 UTC
This is already available in upstream GNOME (2.20) and 10.3, so the "normal" menu bar applet does not show the lock screen option. It is not fixed though on main-menu, which still displays the Lock Screen option for the root user.

Scott, Jimmy?
Comment 31 Scott Reeves 2007-11-05 23:29:39 UTC
Changed gnome-main-menu to work the same way that upstream gnome-panel now does - do not show the lock screen option if logged in as root.

submitted to stable
Comment 32 Jakub Rusinek 2008-02-05 15:26:34 UTC
I think this fix is related to my issue. Logout/Exit and Lock screen gone from my SLAB after some SVN update.
Comment 33 Scott Reeves 2008-02-05 22:35:57 UTC
This change was very limited and directly applied only to not showing the lock screen option when root.  Probably should enter a separate bug with details on your issue.
Comment 34 Jakub Rusinek 2008-02-05 23:25:05 UTC
My fault.
desktop-file-install with --vendor supplied and %files not updated.