Bugzilla – Bug 136687
abiword-2.2.9-3: undefined code
Last modified: 2008-08-14 20:50:19 UTC
I just tried to compile package abiword-2.2.9-3 with a prerelease of the GNU C compiler version 4.1. It said 1. xap_UnixPSGraphics.cpp:1213: warning: operation on "cursor" may be undefined. The source code is g_snprintf(reinterpret_cast<char *>(&hexbuf[0]), sizeof(hexbuf), "%.2X", ( static_cast<UT_Byte>( ( static_cast<float>(*cursor++) * static_cast<float>(1) + static_cast<float>(*cursor++) * static_cast<float>(1) + static_cast<float>(*cursor++) * static_cast<float>(1) ) / static_cast<float>(3.0) )) ); I agree with the compiler - this code seems to be undefined. There are no guarantees in C that arguments are evaluated left to right. Suggest code rework. BTW, the email address of the author [ jeff@abisource.com ] seems to be broken.
abiword is not part of OpenOffice.org; fixing compiliation problems in it should be done by the up-stream developers IMHO.
>should be done by the up-stream developers It looks like this bug report goes to /dev/null, unless someone finds an email address for the upstream developers.
Please re-file the bug here: http://www.abiword.com/support/bugs/, it will of course have been fixed for SL 10.1 - which compiles with gcc 4.1 anyway.
(In reply to comment #3) > Please re-file the bug here: http://www.abiword.com/support/bugs/, it will of > course have been fixed for SL 10.1 - which compiles with gcc 4.1 anyway. Sorry, no. I've already got too many Bugzilla accounts on too many systems. I can't cope with any more. I've tried emailing the author, I've tried telling Suse. Since neither of those approaches have worked, I prefer to stop working on this bug report.
Ah, I am sorry for the late response. I am not the abiword maintainer => reassing to bnc-team-gnome@forge.provo.novell.com
We've had a patch for this for a while now. Upstream the relevant code is gone in the unstable version.