Bug 136688 - bb-1.3-356: undefined C code
Summary: bb-1.3-356: undefined C code
Status: RESOLVED FIXED
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: Final
Hardware: All SuSE Linux 10.0
: P5 - None : Minor
Target Milestone: SUSE Linux 10.1
Assignee: Andreas Schwab
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-02 15:06 UTC by David Binderman
Modified: 2005-12-02 19:39 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2005-12-02 15:06:30 UTC 
I just tried to compile package bb-1.3-356 with a prerelease of the
GNU C compiler version 4.1. It said

1.

zoom.c:324: warning: operation on `ftmp' may be undefined

The source code is

                   myprice += PRICE(pos[p], y);        /*store data */

but

#define PRICE(i,i1) ((((ftmp=((i)-(i1)))*ftmp)*(rangedelta)))

I agree with the compiler - this code seems to be undefined. 

AFAIK, there are no guarantees in C that the left side of a multiply operation
happens before the right side.

Suggest code rework.

2.

zoom.c:354: warning: operation on `ftmp' may be undefined
zoom.c:388: warning: operation on `ftmp' may be undefined
zoom.c:418: warning: operation on `ftmp' may be undefined

Duplicates.

BTW, the email address of the author [ kupsaf@feld.cvut.cz ]
seems to be broken.
Comment 1 Andreas Schwab 2005-12-02 19:39:27 UTC 
Fixed.