Bug 136823 - libdv-0.104-4: undefined C code
Summary: libdv-0.104-4: undefined C code
Status: RESOLVED FIXED
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: Final
Hardware: All SuSE Linux 10.0
: P5 - None : Minor
Target Milestone: ---
Assignee: Gerd Hoffmann
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-03 12:55 UTC by David Binderman
Modified: 2006-09-20 14:47 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2005-12-03 12:55:07 UTC
I just tried to compile package libdv-0.104-4 with a prerelease of the
GNU C compiler version 4.1. It said

1.

encode.c:1811: warning: operation on "i" may be undefined

The source code is

                for (i = 0;
                        i < (DV_WIDTH * (dv_enc->isPAL ? DV_PAL_HEIGHT : DV_NTSC_HEIGHT));
                        dv_enc->img_y[i] = CLAMP(dv_enc->img_y[i++], -224, 214) );

I agree with the compiler - this code seems to be undefined.
Suggest new code

                for (i = 0;
                        i < (DV_WIDTH * (dv_enc->isPAL ? DV_PAL_HEIGHT : DV_NTSC_HEIGHT));
                        (dv_enc->img_y[ i] = CLAMP( dv_enc->img_y[i], -224, 214)), ++i );

BTW, the email address of the author is broken [ omega@cse.ogi.edu ]
Comment 1 Ales Nosek 2006-09-20 14:47:19 UTC
Thank you for the report. The problem is fixed in Factory.