Bug 136851 - abuse-0.7.0-378: undefined C code
Summary: abuse-0.7.0-378: undefined C code
Status: RESOLVED FIXED
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: Final
Hardware: All SuSE Linux 10.0
: P5 - None : Minor
Target Milestone: ---
Assignee: Pavel Nemec
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-04 17:11 UTC by David Binderman
Modified: 2006-02-08 11:12 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2005-12-04 17:11:36 UTC 
I just tried to compile package abuse-0.7.0-378 with a prerelease of the
GNU C compiler version 4.1. It said

1.

palette.cpp:529: warning: operation on "sl" may be undefined.

The source code is

    *(sl++)=(( dest_r-(int)*sl)*fade_on/total_fades+*sl);

I agree with the compiler - this code seems to be undefined. 

AFAIK, there are no guarantees in C that side effects on the left side of an assignment 
are evaluated after the right side.

Suggest code rework.

2.

light.cpp:611: warning: operation on "di" may be undefined.

Duplicate.
Comment 1 David Binderman 2005-12-04 17:12:49 UTC 
I forgot to mention that the email address of the author [ abuse@crack.com ]
seems to be broken
Comment 2 Pavel Nemec 2006-02-08 11:12:33 UTC 
fixed
thanks for report