Bug 136963 - seyon-2.20c-914: undefined C code
Summary: seyon-2.20c-914: undefined C code
Status: RESOLVED FIXED
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: Final
Hardware: All SuSE Linux 10.0
: P5 - None : Minor
Target Milestone: ---
Assignee: Pavel Nemec
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-05 16:55 UTC by David Binderman
Modified: 2005-12-15 10:53 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2005-12-05 16:55:39 UTC
I just tried to compile package seyon-2.20c-914 with a
prerelease of the GNU C compiler version 4.1. It said

1.

SeDial.c:659: warning: operation on `sHold' may be undefined

The source code is

    sprintf(disItemsBuf, qres.dialDirFormat,
            ddItems[n]->name,
            ddItems[n]->number,
            strncmp((sHold = ddItems[n]->baud), "CUR", 3) ? sHold : "????",
            (iHold = ddItems[n]->bits) == 100 ? '?' : itoa(iHold),
            (iHold = ddItems[n]->parity) ? (iHold == 1 ? 'O' :
                                            (iHold == 2 ? 'E' : '?')) : 'N',
            (iHold = ddItems[n]->stopBits) == 100 ? '?' : itoa(iHold),
            strncmp((sHold = ddItems[n]->prefix), "CUR", 3) ?
            strcmp(sHold, qres.dialPrefix) ? 'P' : 'D' : '?',
            strncmp((sHold = ddItems[n]->suffix), "CUR", 3) ?
            strcmp(sHold, qres.dialSuffix) ? 'S' : 'D' : '?',
            ddItems[n]->script);

I agree with the compiler - this code seems to be undefined.

Suggest code rework.
Comment 1 David Binderman 2005-12-05 16:56:40 UTC
I forgot to mention that the email address of the author
[ alsaggaf@mit.edu ] seems to be broken.
Comment 2 Pavel Nemec 2005-12-15 10:53:52 UTC
fixed