Bugzilla – Bug 136963
seyon-2.20c-914: undefined C code
Last modified: 2005-12-15 10:53:52 UTC
I just tried to compile package seyon-2.20c-914 with a prerelease of the GNU C compiler version 4.1. It said 1. SeDial.c:659: warning: operation on `sHold' may be undefined The source code is sprintf(disItemsBuf, qres.dialDirFormat, ddItems[n]->name, ddItems[n]->number, strncmp((sHold = ddItems[n]->baud), "CUR", 3) ? sHold : "????", (iHold = ddItems[n]->bits) == 100 ? '?' : itoa(iHold), (iHold = ddItems[n]->parity) ? (iHold == 1 ? 'O' : (iHold == 2 ? 'E' : '?')) : 'N', (iHold = ddItems[n]->stopBits) == 100 ? '?' : itoa(iHold), strncmp((sHold = ddItems[n]->prefix), "CUR", 3) ? strcmp(sHold, qres.dialPrefix) ? 'P' : 'D' : '?', strncmp((sHold = ddItems[n]->suffix), "CUR", 3) ? strcmp(sHold, qres.dialSuffix) ? 'S' : 'D' : '?', ddItems[n]->script); I agree with the compiler - this code seems to be undefined. Suggest code rework.
I forgot to mention that the email address of the author [ alsaggaf@mit.edu ] seems to be broken.
fixed