Bug 137125 - WindowMaker-applets-1.0-660: undefined C code
Summary: WindowMaker-applets-1.0-660: undefined C code
Status: RESOLVED FIXED
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: Final
Hardware: All SuSE Linux 10.0
: P5 - None : Minor
Target Milestone: ---
Assignee: Vladimir Nadvornik
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-06 11:47 UTC by David Binderman
Modified: 2006-02-02 11:20 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2005-12-06 11:47:32 UTC
I just tried to compile package WindowMaker-applets-1.0-660 with a
prerelease of the GNU C compiler version 4.1. It said

1.

wmcube.c:685: warning: operation on `i' may be undefined

The source code is

	zorder[i+1] = zorder[i--];

I agree with the compiler - this code seems to be undefined.

Suggest new code  

	zorder[i+1] = zorder[i];
	--i;

2.

wmcube.c:959: warning: operation on `i' may be undefined

The source code is

	fscanf(fp,"%d %d",&cline[i++],&cline[i++]);

I agree with the compiler - this code seems to be undefined.

Suggest new code  

	fscanf( fp, "%d %d", &cline[i], &cline[i + 1]);
	i += 2;

BTW, the email address of the author is broken
[ robkli-8@student.luth.se ]
Comment 1 Vladimir Nadvornik 2006-02-02 11:20:59 UTC
fixed for 10.1 beta4