Bug 137126 - xclass-0.9.1-5: undefined C code
Summary: xclass-0.9.1-5: undefined C code
Status: RESOLVED FIXED
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: Final
Hardware: All SuSE Linux 10.0
: P5 - None : Minor
Target Milestone: ---
Assignee: Michal Marek
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-06 11:49 UTC by David Binderman
Modified: 2005-12-06 15:41 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2005-12-06 11:49:35 UTC 
I just tried to compile package xclass-0.9.1-5 with a
prerelease of the GNU C compiler version 4.1. It said

OXHtmlIndex.cc:245: warning: operation on "i" may be undefined

The source code is

	while (i < 45 && isdigit(cp[i])) nbuf[i-1] = cp[i++];

I agree with the compiler - this code seems to be undefined.

Suggest new code  

	while (i < 45 && isdigit(cp[i])) 
	{
		nbuf[i-1] = cp[i];
		++i;
	}

BTW, the email address of the author is broken [ peraza@mitac11.uia.ac.be ]
Comment 1 Michal Marek 2005-12-06 15:41:14 UTC 
Thanks, I've applied the patch for the SUSE package. Unfortunately, there are
bunch of 'may be used uninitialized warnings' too :-(