Bug 138290 - dvbd-0.7.7-10: array subscript out of range
Summary: dvbd-0.7.7-10: array subscript out of range
Status: VERIFIED FIXED
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: unspecified
Hardware: All SUSE Other
: P5 - None : Minor
Target Milestone: ---
Assignee: Forgotten User ZhJd0F0L3x
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-13 15:30 UTC by David Binderman
Modified: 2007-06-05 11:20 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2005-12-13 15:30:45 UTC 
just tried to compile package dvbd-0.7.7-10 with a non standard version of the
GNU C compiler 

It said

remux.c:467: warning: array subscript out of range
remux.c:468: warning: array subscript out of range

The source code is

                uint8_t b[3];

                vring_peek( rem, b, 4, 0);
                if ( b[0] == 0x00 && b[1] == 0x00 && b[2] == 0x01
                     && b[3] == 0xb3) found = 4;

Clearly broken code. b[ 3] doesn't exist. Suggest make local array one bigger.

I tried to email the author [ jak@users.sourceforge.net ] , but got no answer.
Comment 1 Forgotten User ZhJd0F0L3x 2005-12-13 15:59:24 UTC 
thanks for the report. I'll look into this. It might very well be that this is an error in one of my patches and Johns original code is fine.
Comment 2 Forgotten User ZhJd0F0L3x 2005-12-21 15:50:13 UTC 
Ok, it was none of my patches :-)
I have submitted a fixed version to source repository which will appear in one of the next builds of 10.1 alpha. If you need a 10.0 rpm let me know and i'll build you one.

Thanks again for the report!