Bugzilla – Bug 138555
ini parser for smb.conf does not handle include parameter correctly
Last modified: 2006-01-04 13:45:20 UTC
When using yast2-samba-client (this will apply to other modules as well), the ini parser does not handle include files correctly. When you have several include parameters in your smb.conf ([global] section) and some are commented out (with a leading #) then only the last active include parameter survives. Example: ------------------------ [global] foo = bar bar = foo include = /tmp/test1 # include = /tmp/test2 # include = /tmp/test3 foobar = yes barfoo = no include = /tmp/test4 ------------------------- After yast2 has modified a parameter in that file, only "include = /tmp/test4" is still in the configuration file, all other include paramters are deleted.
smb agent probably don't expect non-unique keys
It might be possible to adapt smb ini-agent to do not break such config file. But I hope you don't expect that the included files will be parsed.
Created attachment 60954 [details] patch for /usr/share/YaST2/scrconf/cfg_smbconf.scr patch for agent definition
Created attachment 60955 [details] patch for /usr/share/YaST2/modules/SambaConfig.pm ... and patch for module
could you test how it works with patches?
Current yast2-samba-client from STABLE (2.13.1) already includes this patch.
Hmm, no response -> FIXED.