Bug 140092 - xstereograph-2.1-575: local variable used before set
Summary: xstereograph-2.1-575: local variable used before set
Status: RESOLVED FIXED
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: unspecified
Hardware: All SUSE Other
: P5 - None : Minor
Target Milestone: ---
Assignee: Michal Marek
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-18 08:13 UTC by David Binderman
Modified: 2006-01-03 13:28 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2005-12-18 08:13:30 UTC 
I just tried to compile package xstereograph-2.1-575 with a GNU C compiler

It said

xstereograph.c:1084: warning: "data" is used uninitialized in this function

The source code is

   wid_main[++n] = MakeButton("Config ", Config, data);

I have read the source code, and I agree with the compiler.
Suggest code rework.
Comment 1 Michal Marek 2006-01-03 13:28:43 UTC 
Config is a callback function and data is its argument, which Config doesn't
make use of, so this warning is harmless. But to silence the warning, I
replaced all the unused 'data' arguments with NULL (I can attach the patch if
you want).

Thanks for both your reports!