Bug 141851 - sane-frontends-1.0.14-2: array subscript out of range
Summary: sane-frontends-1.0.14-2: array subscript out of range
Status: RESOLVED FIXED
: 134418 (view as bug list)
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: unspecified
Hardware: All SUSE Other
: P5 - None : Minor
Target Milestone: ---
Assignee: Johannes Meixner
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-06 19:44 UTC by David Binderman
Modified: 2006-03-27 14:17 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2006-01-06 19:44:57 UTC 
I just tried to compile package sane-frontends-1.0.14-2 with a non standard
version of the GNU C compiler

It said

xcam.c:1290: warning: array subscript out of range

The source code is

	testfilename[sizeof (testfilename)] = 0;

Clearly broken code. Suggest 

	testfilename[sizeof (testfilename) - 1] = 0;
Comment 1 Johannes Meixner 2006-01-09 13:49:53 UTC 
*** Bug 134418 has been marked as a duplicate of this bug. ***
Comment 2 Johannes Meixner 2006-01-17 16:06:54 UTC 
Fixed package submitted to STABLE.
Comment 3 Johannes Meixner 2006-01-18 09:25:21 UTC 
FYI: Also fixed upstream:
http://lists.alioth.debian.org/pipermail/sane-devel/2006-January/015946.html
Comment 4 David Binderman 2006-03-24 21:14:31 UTC 
(In reply to comment #3)
> FYI: Also fixed upstream:

Strange. It seems to be still broken a couple of months
later in Suse Factory.

I am not sure how this has happened.
Comment 5 Johannes Meixner 2006-03-27 14:05:53 UTC 
Argl!
You are right!
I fixed it only in xscanimage.c according to bug #134418
because I simply missed that this bug is about xcam.c!
Sorry!
Will fix it also for xcam.c.
Comment 6 Johannes Meixner 2006-03-27 14:17:55 UTC 
Fixed and submitted to STABLE.