Bug 143294 - dsp_spos_scb_lib.c: dodgy code
Summary: dsp_spos_scb_lib.c: dodgy code
Status: RESOLVED INVALID
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Kernel (show other bugs)
Version: unspecified
Hardware: All SUSE Other
: P5 - None : Minor
Target Milestone: ---
Assignee: E-mail List
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-15 21:52 UTC by David Binderman
Modified: 2006-01-15 23:33 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2006-01-15 21:52:29 UTC 
I just tried to compile kernel 2.6.15.1 with the Intel C compiler. 

It said

sound/pci/cs46xx/dsp_spos_scb_lib.c(673): warning #187: use of "=" where "==" may have been intended

The source code is

           snd_assert (rate = 48000);

I agree with the compiler. Suggest new code

           snd_assert (rate == 48000);

Also, the email address of the author [ twoller@crystal.cirrus.com ]
seems to be broken.
Comment 1 Greg Kroah-Hartman 2006-01-15 23:33:27 UTC 
Please report this to bugzilla.kernel.org, as it is a upstream issue.