Bug 143729 - ifup broken for modems.
Summary: ifup broken for modems.
Status: VERIFIED FIXED
Alias: None
Product: SUSE Linux 10.1
Classification: openSUSE
Component: Network (show other bugs)
Version: Beta 1
Hardware: Other Other
: P5 - None : Blocker (vote)
Target Milestone: ---
Assignee: Christian Zoz
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 140732
  Show dependency treegraph
 
Reported: 2006-01-18 11:12 UTC by Forgotten User ZhJd0F0L3x
Modified: 2006-06-13 10:37 UTC (History)
2 users (show)

See Also:
Found By: Component Test
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
script to dial-in / hangup via smpppd. (353 bytes, text/plain)
2006-01-18 17:34 UTC, Forgotten User ZhJd0F0L3x
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Forgotten User ZhJd0F0L3x 2006-01-18 11:12:02 UTC
Network is configured to use networkmanager

root@strolchi:/etc/sysconfig/network> ifup modem0
Network interface is managed from NetworkManager
NetworkManager will be advised to set up modem0
but it cannot be assured from here.
root@strolchi:/etc/sysconfig/network> 

NetworkManager uses ifup to set up modem connections. BOOM.
Comment 1 Christian Zoz 2006-01-18 11:58:26 UTC
Switch of NM and modem will work.

File a bug against NM if it cannot deal with modems.
Comment 2 Forgotten User ZhJd0F0L3x 2006-01-18 12:38:09 UTC
it does not work, so it cannot be "fixed".
Comment 3 Forgotten User ZhJd0F0L3x 2006-01-18 12:38:51 UTC
since this now seems to be a NM bug...
Comment 4 Robert Love 2006-01-18 14:35:34 UTC
It is not an NM bug.

NM needs "ifup modem0" to work.
Comment 5 Christian Zoz 2006-01-18 16:48:37 UTC
It is a NM bug if it cannot deal with modems. It seems NM is good for almost nothing. It is just a blown up ifplugd. Wow, powerfull.
Comment 6 Robert Love 2006-01-18 17:00:03 UTC
I am sorry that you feel that way.

NetworkManager uses the networking scripts for PPP connections and nothing else.  This is because the SUSE dialup infrastructure is very advanced and complete and I did not want to spend my initial development time reimplementing the wheel.  In the future, NM will hopefully handle PPP itself, but for now it relies on ifup and ifdown.

"ifup modem0" worked prior to the latest changes that deliberate bail out when it is detected that NM is running.  I understand the intention behind this change -- it makes sense -- but it conflicts with NM with respect to PPP devices.  So, just for PPP devices, we need to revert the check and allow NM to ifup/ifdown the interface.
Comment 7 Timo Hoenig 2006-01-18 17:00:17 UTC
I'm happy to work on this.  Christian, are you willing to accept patches for sysconfig?  One that will be removed once we have a proper backend for dial-up devices in NM.
Comment 8 Timo Hoenig 2006-01-18 17:02:24 UTC
(mid-air collision. NEEDINFO from Christian was my intention)
Comment 9 Robert Love 2006-01-18 17:06:27 UTC
Thank you, Timo.  I would be happy to help, too.

I think we just need a very simple change, to allow PPP devices to be up'ed and down'ed even if NM is running.
Comment 10 Forgotten User ZhJd0F0L3x 2006-01-18 17:10:01 UTC
no sysconfig patches needed.

I'll write two scripts that take the interface name as an argument and dial in / hangup the interface via cinternet.
Comment 11 Christian Zoz 2006-01-18 17:13:01 UTC
No that makes still much less sense. ifup is that script.
Comment 12 Christian Zoz 2006-01-18 17:13:36 UTC
Wait until tomorrow. I'm in a very bad mood today.
Comment 13 Forgotten User ZhJd0F0L3x 2006-01-18 17:16:03 UTC
but this would also solve my "ifup modemU" problem :-) and it is already finished.
Comment 14 Forgotten User ZhJd0F0L3x 2006-01-18 17:34:34 UTC
Created attachment 63875 [details]
script to dial-in / hangup via smpppd.

Robert, this works for me (may probably need some tweaking for dial-on-demand setups, i'll try this with ISDN) and could be used instead of "ifup $iface" and "ifdown $iface". Just create a symlink nm-hangup to nm-dial and call this with the interface name.

e.g:
nm-dial modem0
Comment 15 Robert Love 2006-01-18 17:43:59 UTC
Danke, seife!

Looks good to me, but let's see what Zoz says.  He is right that ifup is supposed to be "the" script in this case.  Whatever he thinks is best.  But, if needed, this is great.
Comment 16 Christian Zoz 2006-01-23 18:52:56 UTC
Zoz says, i'll fix that, no doubt. ;)
Comment 17 Christian Zoz 2006-01-23 18:55:05 UTC
ifup will now assume NM_CONTROLLED=no if
- interfacetype is eth, tr or wlan
- NM_CONTROLLED is not set in config file

I'll submit that for beta2.

Is that ok for you?
Comment 18 Forgotten User ZhJd0F0L3x 2006-01-23 19:07:33 UTC
(In reply to comment #17)
> ifup will now assume NM_CONTROLLED=no if
> - interfacetype is eth, tr or wlan

interfacetype is NOT(eth OR tr OR wlan) of course.

> - NM_CONTROLLED is not set in config file
> 
> I'll submit that for beta2.
> 
> Is that ok for you?

fine with me. NM right now really only handles LAN/WLAN, the rest of the network is not handled by NM.

Comment 19 Robert Love 2006-01-23 19:09:44 UTC
Fine with me, too.

Do we need YaST bits to ensure that NM_CONTROLLED is not set for modems?  It might already be the case.
Comment 20 Christian Zoz 2006-01-23 19:11:23 UTC
YaST does not know this variable.

package sysconfig is submitted.
Comment 21 Robert Love 2006-01-23 19:15:35 UTC
Alright, thanks.
Comment 22 Forgotten User ZhJd0F0L3x 2006-06-13 10:37:08 UTC
works in final