Bugzilla – Bug 144598
imap-2004g_suse-4: dodgy code
Last modified: 2006-11-16 10:12:57 UTC
I just tried to compile package imap-2004g_suse-4 with the Intel C compiler. It said 1. env_unix.c(1206): warning #187: use of "=" where "==" may have been intended The source code is (read (fd,tmp,i) == i) && !(tmp[i] = 0) && ((i = atol (tmp)) > 0)) I agree with the compiler. Suggest new code (read (fd,tmp,i) == i) && !(tmp[i] == 0) && ((i = atol (tmp)) > 0)) 2. imap4r1.c(1814): warning #187: use of "=" where "==" may have been intended The source code is (aflg.text = "-FLAGS \\Seen")) || I agree with the compiler. May new code (aflg.text == "-FLAGS \\Seen")) || or maybe (strcmp( aflg.text, "-FLAGS \\Seen") == 0)) || would be better 3. imap4r1.c(1816): warning #187: use of "=" where "==" may have been intended Duplicate. 4. nntp.c(848): warning #187: use of "=" where "==" may have been intended The source code is if ((elt = mail_elt (stream,i))->sequence && (elt->valid = T) && I agree with the compiler. Suggest new code if ((elt = mail_elt (stream,i))->sequence && (elt->valid == T) &&
Thanks for the report. I'll have a look at this. (Now i know why everybody hates the UW IMAP code... ;-)
re-assign to new maintainer.
i think this is fixed in the new version of imap. i update asap.
i submit the new version into stable => fixed