Bugzilla – Bug 147377
installation -> system repair doesn't handle LVM volumes
Last modified: 2006-03-20 10:20:51 UTC
I do have a few old installations lying around, however my current beta3 install is on LVM. If I select "system repair" at the installation screen, all partitions are checked, however no LVM volume is checked. Even worse, at one point I'm forced to select the correct root partition, but since it is on LVM it is not listed and I only have an OK button. y2logs follow.
Created attachment 66085 [details] y2logs
Please attach the output of `fdisk -l'.
This is already in the tarball (it has everything in /var/log/YaST2).
Is this another system than in bug #147366? Please also attach the required files here (`fdisk -l', vgscan, resulting fstab).
Ok, I talked to the maintainer. Please provde more information about your LVM-configuration here.
This is the same system as in bug #147366. Please look at attachment 66368 [details] which should contain all the info you need. fdisk-l_hda fdisk-l_hdb lvdisplay.txt pvdisplay.txt vgdisplay.txt
Reassign to Yast developer... Adding sf to CC in case this could have something to do with recent bootloader changes ...
Reassigned to maintainer of yast2-repair.
*** Bug 156602 has been marked as a duplicate of this bug. ***
The log file doesn't include any antry from yast2-repair module. Please try running it on installed system ('/sbin/yast2 repair'), if it doesn't handle LVM correctly, it should be seen on installed system as well. Provide correct logs after that (Carl-Daniel or Alex)
Hi Jiri, what log are you looking for? I run the repair on a running system, but there is no file in /var/log/yast2 that would match the time the repair was running
Created attachment 72819 [details] log after repair on LVM OK, running it as root provided the needed log :-)
Created attachment 72965 [details] patch for /usr/share/YaST2/modules/OSRFstab.ycp Alex, please patch your /usr/share/YaST2/modules/OSRFstab.ycp with this patch, call 'ycpc -c /usr/share/YaST2/modules/OSRFstab.ycp', run yast2-repair again (preferably with LANG=C) and attach the new logfiles (better the whole /var/log/YaST2 directory than just y2log)
(Sorry for "Alex"m I mean Axel)
> (Sorry for "Alex"m I mean Axel) not the first time :-) z60m:/usr/share/YaST2/modules # patch -p0 OSRFstab.ycp /home/axel/OSRFstab.diff patching file OSRFstab.ycp Hunk #1 succeeded at 249 with fuzz 1 (offset -1 lines). Hunk #2 succeeded at 298 (offset -2 lines). Hunk #3 succeeded at 329 (offset -2 lines). Hunk #4 succeeded at 338 (offset -2 lines). Hunk #5 succeeded at 365 (offset -2 lines). z60m:/usr/share/YaST2/modules # /sbin/yast2 repair -> didnt find root partition again
Created attachment 72996 [details] YaST2 logs after repair with applied patch
Sorry, by could you try again without forgetting to call 'ycpc -c /usr/share/YaST2/modules/OSRFstab.ycp'? From these logs it looks like you forgot to do so... > -> didnt find root partition again I added only more logging informations, so yes, it will fail again.
Created attachment 73003 [details] once again....with
Created attachment 73260 [details] package for testing I'm still bit confused by some parts of the logs. Let's do another test: here is the package, adding even more logging. Please install it, run again 'yast2 repair' and attach the logs afterwards.
And please, run the module with 'LANG=C yast2 repair' or 'LANG=en_US yast2 repair', so there are not german messages in the log.
Created attachment 73285 [details] Log files w ext. logging Hope it worked this time with the language
The root partition (on LVM) has this description: $["detected_fs":`reiser, "device":"/dev/z60system/root", "fstopt":"acl,user_xattr", "fstype":"LV", "mount":"/", "name":"root", "size_k":8388608, "stripes":1, "type":`lvm, "used_fs":`reiser, "uuid":"7d41d493-ff92-4cdf-bec4-09197c130f43"] (y2log line 7080) It's a submap of "partitions" list from Storage::GetTargetMap() for /dev/z60system device. Thomas, why the partition map doesn't include "fsid" key?
The fsid key is only present for partitions of a real disk. It contains the partition id from a msdos partitions table (e.g. 0x83 for linux partitions, 0x82 for swap partitions). LVM volumes, Software Raids and other such artificial entities do not have such a fsid (maybe this is a change in comparison to pre-code10 maps).
Created attachment 73689 [details] new package OK; let's try again with this package
Created attachment 73697 [details] log files Looks good - root partition recognized and mounted!
ok, fixed