Bugzilla – Bug 149021
passwd -e does not work anymore for local users with pam_winbind
Last modified: 2006-02-14 15:20:28 UTC
how to reproduce: * create local user * passwd -e <username> * login with username -> no expiration
Ok, pam_winbind should better not return PAM_SUCCESS in pam_sm_acct_mgmt when the existance of the user has just been verified using NSS calls. The attached patch still has a quirk in the WINBINDD_LOOKUPNAME which will cause an additional delay when logging in, working on that right now.
Created attachment 66977 [details] let pam_winbind not only rely on getpwnam
Created attachment 67208 [details] Updated Patch to better identify whether a user is a winbind user or not The new fix touches some essential codepaths and still must be thoroughly tested.
Yes, this will definately exercise winbindd to detect a winbindd-returned user. The only thing I hate is "parse_valid_domain_user" as well as parse_domain_user - can you make it really clear as to why this exists. As far as I can see this is the same except for the block : + if (!lp_winbind_use_default_domain() || + !lp_winbind_trusted_domains_only()) { + return False; + } Any way you can make this common and select with a flag instead ? Jeremy.
Created attachment 67689 [details] Fixed version of that patch Ok, I fixed that (while fixing parse_domain_user() directly). If no one shouts, I commit that upstream and to autobuild.
Created attachment 67690 [details] Fixed version of that patch Ok, I fixed that (while fixing parse_domain_user() directly). If no one shouts, I commit that upstream and to autobuild.
Fixed upstream
This is in autobuild right now. Closing this bug.