Bugzilla – Bug 149673
hplip init script is redhat style uses daemon instead of startproc and output is redhat style
Last modified: 2008-06-25 09:53:36 UTC
the hp printer driver includes an init script in /etc/init.d/hplip it works but it is a redhat style script it uses daemon /command instead of startproc killproc and so on... so i wrote a new one with start/killproc startup/shutdown and output messages more in line with SuSE's style... (* really i just gutted the cyrus init script and replaced with hplip stuff *) #! /bin/sh # # Author: skog <skoglinux@yahoo.com> # # /etc/init.d/hplip # ### BEGIN INIT INFO # Provides: hplip # Required-Start: # Required-Stop: # Default-Start: 2 3 5 # Default-Stop: # Description: start the hplip service ### END INIT INFO # Determine the base and follow a runlevel link name. base=${0##*/} link=${base#*[SK][0-9][0-9]} HPIOD_BIN=/usr/sbin/hpiod HPSSD_BIN="/usr/bin/python /usr/share/hplip/hpssd.py" PID_HPIOD_FILE=/var/run/hpiod.pid PID_HPSSD_FILE=/var/run/hpssd.pid test -x $HPIOD_BIN || exit 5 # # $HPSSD_BIN is a 2 part command so checking that both parts are executable # test -x `/bin/echo $HPSSD_BIN | /usr/bin/cut -f 1 -d " "` || exit 5 test -x `/bin/echo $HPSSD_BIN | /usr/bin/cut -f 2 -d " "` || exit 5 # Shell functions sourced from /etc/rc.status: # rc_check check and set local and overall rc status # rc_status check and set local and overall rc status # rc_status -v ditto but be verbose in local rc status # rc_status -v -r ditto and clear the local rc status # rc_failed set local and overall rc status to failed # rc_failed <num> set local and overall rc status to <num><num> # rc_reset clear local rc status (overall remains) # rc_exit exit appropriate to overall rc status . /etc/rc.status # First reset status of this service rc_reset # Return values acc. to LSB for all commands but status: # 0 - success # 1 - generic or unspecified error # 2 - invalid or excess argument(s) # 3 - unimplemented feature (e.g. "reload") # 4 - insufficient privilege # 5 - program is not installed # 6 - program is not configured # 7 - program is not running # # Note that starting an already running service, stopping # or restarting a not-running service as well as the restart # with force-reload (in case signalling is not supported) are # considered a success. case "$1" in start) echo -n "Starting HPLIP service (hpiod)" ## Start daemon with startproc(8). If this fails ## the echo return value is set appropriate. # NOTE: startproc return 0, even if service is # already running to match LSB spec. /sbin/startproc -p $PID_HPIOD_FILE $HPIOD_BIN > /dev/null 2>&1 # Remember status and be verbose rc_status -v echo -n " (hpssd)" /sbin/startproc -p $PID_HPSSD_FILE $HPSSD_BIN > /dev/null # Remember status and be verbose rc_status -v ;; stop) echo -n "Shutting down hplip service (hpiod)" ## Stop daemon with killproc(8) and if this fails ## set echo the echo return value. /sbin/killproc -p $PID_HPIOD_FILE -TERM $HPIOD_BIN > /dev/null 2>&1 # Remember status and be verbose rc_status -v echo -n " (hpssd)" /sbin/killproc -p $PID_HPSSD_FILE -TERM $HPSSD_BIN > /dev/null 2>&1 # Remember status and be verbose rc_status -v ;; try-restart) ## Stop the service and if this succeeds (i.e. the ## service was running before), start it again. ## Note: try-restart is not (yet) part of LSB (as of 0.7.5) $0 status >/dev/null && $0 restart # Remember status and be quiet rc_status ;; restart) ## Stop the service and regardless of whether it was ## running or not, start it again. $0 stop $0 start # Remember status and be quiet rc_status ;; force-reload) ## Signal the daemon to reload its config. Most daemons ## do this on signal 1 (SIGHUP). ## If it does not support it, restart. echo -n "Reload service hplip (hpiod)" /sbin/killproc -p $PID_HPIOD_FILE -HUP $HPIOD_BIN rc_status -v echo -n " (hpssd)" ## if it supports it: /sbin/killproc -p $PID_HPSSD_FILE -HUP $HPSSD_BIN rc_status -v ## Otherwise: #$0 stop && $0 start #rc_status ;; reload) ## Like force-reload, but if daemon does not support ## signalling, do nothing (!) echo -n "Reload service hplip (hpiod)" # If it supports signalling: /sbin/killproc -p $PID_HPIOD_FILE -HUP $HPIOD_BIN #touch /var/run/FOO.pid rc_status -v echo -n " (hpssd)" /sbin/killproc -p $PID_HPSSD_FILE -HUP $HPSSD_BIN #touch /var/run/FOO.pid rc_status -v ## Otherwise if it does not support reload: #rc_failed 3 #rc_status -v ;; status) echo -n "Checking for service hplip: (hpiod):" ## Check status with checkproc(8), if process is running ## checkproc will return with exit status 0. # Status has a slightly different for the status command: # 0 - service running # 1 - service dead, but /var/run/ pid file exists # 2 - service dead, but /var/lock/ lock file exists # 3 - service not running # NOTE: checkproc returns LSB compliant status values. /sbin/checkproc -p $PID_HPIOD_FILE $HPIOD_BIN rc_status -v echo -n " (hpssd):" /sbin/checkproc -p $PID_HPSSD_FILE $HPSSD_BIN rc_status -v ;; *) echo "Usage: $0 {start|stop|status|try-restart|restart|force-reload|reload}" exit 1 ;; esac rc_exit
I know. Many thanks for the "startproc/killproc" version. I don't know if a the Red Hat stlye is a bug. If it is LSB compliant it should be o.k. I kept it as it was in the sources from HP except the following changes: --------------------------------------------------------------------------- -HPIODDIR= -HPSSDDIR= +HPIODDIR=/usr/sbin +HPSSDDIR=/usr/share/hplip -# killall -HUP cupsd + echo "Note: You may have to restart the cupsd." --------------------------------------------------------------------------- My general modus operandi is to keep the original software as much as possible because I want to be as much as possible in compliance with what HP does. This way Suse users can ask questions about HPLIP on non-Suse mailing lists and even non-Suse users can help them. I will keep it in mind as possible enhancement for next version but when the current style is LSB compliant, I will keep it as is.
After 10.1 => LATER.
mass reopening all SuSE Linux bugs that are set to REMIND+LATER to change the resolution to WONTFIX (adapting to new policy)
Closing old LATER+REMIND bugs as WONTFIX - if you still plan to work on it, feel free to reopen and set to ASSIGNED. In case the report saw repeated reopen comments, it's due to bugzilla timing out on the huge request ;(