Bug 150400 - glade-2.12.1-4: dodgy code
Summary: glade-2.12.1-4: dodgy code
Status: RESOLVED INVALID
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: unspecified
Hardware: All SuSE Linux 10.1
: P5 - None : Minor
Target Milestone: ---
Assignee: E-mail List
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-13 13:28 UTC by David Binderman
Modified: 2006-02-13 13:48 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2006-02-13 13:28:18 UTC 
I just tried to compile package glade-2.12.1-4 with the Intel C compiler.

It said

gbwidget.c(405): warning #187: use of "=" where "==" may have been intended

The source code is

    g_return_val_if_fail ((new_widget = NULL), NULL);

Suggest code rework. Maybe the programmer intended

    g_return_val_if_fail ((new_widget == NULL), NULL);
Comment 1 Michael Gross 2006-02-13 13:48:05 UTC 
David: Please don't report these issues unless there is an actual problem. Specially don't report warnings from icc, SUSE Linux is getting compiled with gcc.

And as the compiler says correctly here: It _may_ have.