Bug 151370 - yast2-ncurses carries 14MB documentation
Summary: yast2-ncurses carries 14MB documentation
Status: RESOLVED FIXED
Alias: None
Product: SUSE Linux 10.1
Classification: openSUSE
Component: YaST2 (show other bugs)
Version: Beta 3
Hardware: x86-64 SuSE Linux 10.1
: P5 - None : Enhancement with 1 vote (vote)
Target Milestone: ---
Assignee: Martin Vidner
QA Contact: Klaus Kämpf
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-16 01:35 UTC by Marcus Rückert
Modified: 2006-02-21 17:02 UTC (History)
1 user (show)

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus Rückert 2006-02-16 01:35:29 UTC
the content of /usr/share/doc/packages/yast2-ncurses/autodocs/ looks like doxygen documentation. do we really need those on any installed system?

[[[
# rpm -qlv yast2-ncurses | grep -v '/usr/share/doc/packages/yast2-ncurses/autodocs/'
-rw-r--r--    1 root    root             1188 Jan 31 07:41 /usr/lib64/YaST2/plugin/libpy2ncurses.la
lrwxrwxrwx    1 root    root               22 Jan 31 07:41 /usr/lib64/YaST2/plugin/libpy2ncurses.so -> libpy2ncurses.so.2.0.0
lrwxrwxrwx    1 root    root               22 Jan 31 07:41 /usr/lib64/YaST2/plugin/libpy2ncurses.so.2 -> libpy2ncurses.so.2.0.0
-rwxr-xr-x    1 root    root          1624592 Jan 31 07:42 /usr/lib64/YaST2/plugin/libpy2ncurses.so.2.0.0
-rw-r--r--    1 root    root             6160 Jan 24  2005 /usr/share/YaST2/data/pkg_layout.ycp
-rw-r--r--    1 root    root             2988 Jan 24  2005 /usr/share/YaST2/data/you_layout.ycp
drwxr-xr-x    2 root    root                0 Jan 31 07:42 /usr/share/doc/packages/yast2-ncurses
-rw-r--r--    1 root    root            17992 Jan 24 17:00 /usr/share/doc/packages/yast2-ncurses/COPYING
-rw-r--r--    1 root    root            17992 Jan 24 17:00 /usr/share/doc/packages/yast2-ncurses/COPYRIGHT.english
-rw-r--r--    1 root    root               79 Jan 24 17:00 /usr/share/doc/packages/yast2-ncurses/README
drwxr-xr-x    2 root    root                0 Jan 31 07:42 /usr/share/doc/packages/yast2-ncurses/autodocs
]]]

that makes 1.7MB code and 14MB api documentation.

maybe we should move the documentation into a subpackage.
Comment 1 Andreas Jaeger 2006-02-16 08:04:01 UTC
Such a split is ok with me.
Comment 2 Martin Vidner 2006-02-16 20:12:02 UTC
OK.
How about qt? The ratio is not as bad there though.
Comment 3 Marcus Rückert 2006-02-16 20:53:53 UTC
yast2-qt or qt in general?:)

if you refer to yast-qt ... for the sake of consistency ... i would say split it aswell.

Comment 4 Stefan Hundhammer 2006-02-17 10:42:58 UTC
I would say we have a zillion better things to do right now. AFAIK snwint kicks out unneeded stuff from the inst-sys anyway.
Comment 5 Steffen Winterfeldt 2006-02-17 11:29:06 UTC
Exactly. Feel free to write terabytes of documentation.
Comment 6 Marcus Rückert 2006-02-17 11:44:37 UTC
i dont have any problems doing the few spec file changes on my own.
i just wanted an OK from you. so if you are fine with it. i will submit packages with split of documentation and do the PDB changes.

fine with you?
Comment 7 Martin Vidner 2006-02-17 11:49:50 UTC
sure, thanks :)
Comment 8 Marcus Rückert 2006-02-17 12:50:20 UTC
1a2,7
> Fri Feb 17 13:46:16 CET 2006 - mrueckert@suse.de
> 
> - split the doxygen docs into  their own package.
>   yast2-ncurses-devel-docs
> 
> -------------------------------------------------------------------
running check_dates_in_changes
performing spec file checks .
yast2-ncurses: Group is System/YaST ...ok
yast2-ncurses-devel-docs: Group is System/YaST ...ok

Ok. Remember to have fun...
Comment 9 Stanislav Visnovsky 2006-02-17 13:04:24 UTC
From suse-dist:
This does not make any sense, the docu generated is useful only for the 
yast2-ncurses developer. This is not a development lib. The generated doxygen 
HTML should not be packaged at all.
Comment 10 Stanislav Visnovsky 2006-02-17 13:05:25 UTC
Stefan, what about yast2-qt?
Comment 11 Marcus Rückert 2006-02-17 13:38:48 UTC
i have a splitted version of this package too. i can just submit this package aswell if you want.
Comment 12 Stefan Hundhammer 2006-02-17 14:33:00 UTC
I tend to agree with Stano that this documentation is only useful for programming the UI (as opposed to programming _with_ the UI, i.e., write YCP dialogs) anyway. We should not package it to begin with. Those who want to extend the UI need the sources anyway, and all those docs are auto-generated from the sources.
Comment 13 Stanislav Visnovsky 2006-02-17 14:36:24 UTC
Martin, please, fix it on one of the next submits. Thanks!
Comment 14 Stefan Hundhammer 2006-02-17 15:19:32 UTC
I found that unfortunately Automake doesn't support noinst_DATA (as opposed to noinst_PROGRAMS, noinst_LIBS), so the only way to not build and distribute that is to omit "autodocs" from "SUBDIRS" in doc/Makefile.am .

As an added benefit, you don't have to wait all the time until all that HTML gets generated and installed.
Comment 15 Stanislav Visnovsky 2006-02-17 15:24:05 UTC
What about defining generating as a special target to be invoked manually?
Comment 16 Stefan Nordhausen 2006-02-19 14:58:20 UTC
Please also remove the autodocs of the other yast modules. On my Suse 10.0 default install I have a total of 26MB of useless autodocs from yast in 53 directories.
Comment 17 Martin Vidner 2006-02-20 09:10:45 UTC
OK, I will remove the docs from yast2-ncurses and drop yast2-ncurses-devel-docs. Marcus, sorry for the extra work, I did not realize it before.

Comment 16:
The autodocs are indeed useful only in yast2-core, other C++ packages blindly copied its packaging style without realizing that they export no API to document.
All C++ packages should be changed to use a unified automake include file that will generate the autodocs on a manual target (coment 15).

Comment 14:
Of course, because data that is not installed is useless (and only consumes build power), as opposed to not installed programs (which may be used to generate installed data).
Comment 18 Martin Vidner 2006-02-21 16:48:56 UTC
yast2-ncurses-2.13.9 no longer has the autodocs.
yast2-devtools-2.13.9 provides a simple way for the maintainers to do the same in their packages.
Comment 19 Stefan Hundhammer 2006-02-21 17:02:11 UTC
Did the same for yast2-qt.