Bug 151489 - minicom-2.1-149: 2 * subscript out of range
Summary: minicom-2.1-149: 2 * subscript out of range
Status: RESOLVED FIXED
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: unspecified
Hardware: All SuSE Linux 10.1
: P5 - None : Normal
Target Milestone: ---
Assignee: Marian Jancar
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-16 13:44 UTC by David Binderman
Modified: 2006-02-27 16:58 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2006-02-16 13:44:46 UTC 
I just tried to compile package minicom-2.1-149 with the Intel C 
compiler.

It said

1.

util.c(298): warning #175: subscript out of range

The source code is

  static char loc_port_list[PARS_VAL_LEN];
  static char *sp = NULL;
  static char *ep;

  /* first pass? */
  if(sp == NULL) {
    strncpy(loc_port_list, port_list, PARS_VAL_LEN);
    loc_port_list[PARS_VAL_LEN] = (char) 0;

Clearly broken code. Suggest make array one bigger.

2.

util.c(310): warning #175: subscript out of range

The source code is

	next_port[PARS_VAL_LEN] = (char) 0;

Clearly broken code. Suggest make array one bigger.
Comment 1 Anna Maresova 2006-02-27 16:58:07 UTC 
fixed