Bugzilla – Bug 151813
Package Selection of Installtion still doesn't work correctly for laptops without PCMCIA controllers
Last modified: 2006-03-09 14:33:23 UTC
On Laptops without PCMCIA slots the Package Selection will not install the Package Group Laptop by default. It seems that YaST still checks for a PCMCIA controller. There exists many subnotebooks without PCMCIA. YaST should only check for the formfactor of HAL. The network module of YaST seems to have (meanwhile) no problem by detecting a laptop (independent of PCMCIA), NetworkManager is select by default. You can find these discssion at #149976 and #149909 Do you need yast logs of the laptops without PCMCIA or further information?
Its quite hard to prove/deny you assumptions without logs ...
Well... just to be on the safe side: Daniel, please attach the logs, I'll reassign it afterwards.
IMO Yast does not use HAL to check if the machine is a laptop (if it would this should not happen because the machines are correct detected in HAL). But it should. See fate feature #100199. This was implemented in HAL someone in the last year. You should check hal for key system.formfactor=laptop. This should detect nearly all machines.
YaST uses hwinfo which should use HAL
Created attachment 69070 [details] yast logs of intel development laptop
Created attachment 69072 [details] YaST logs of Medion MIM2080 - no PCMCIA controller
Klaus, yast uses .probe.has_pcmcia (via Arch::has_pcmcia()) from hwinfo. IMO it would be confusing to change the semantics of this to mean "laptop". Yast (Packages.ycp) should use the new API. Implementation note: .probe.system is a LIST (singleton?) of maps.
Steffen: Can you provide a comment here?
I hate this changes of the BST. This is a blocker since the most new laptops has no PCMCIA slot.
hwinfo reads the formfactor entry from hal and provides it via .probe.system (I think). The ancient .probe.has_pcmcia should not be used as a base for laptop detection (it was never intended for this - it originates from times where we had a special 'laptop' kernel with pcmcia compiled in).
Jiri: I suppose this is something for you. If not please assgign it back to us.
Please use Arch::is_laptop () which I will submit shortly.
Stano fixed it.
It is still not working for non-pcmcia machines in beta 5. Is the fixed package of yast (>= 2.13.31) also in the installtion system of beta5? When i check for package version after installtion (beta5) it seems to be the package which should fix this problem (Version 2.13.31). Maybe on the installtion system is an older version of the yast package? Please close this bug when the version of yast, on the installtion system of beta5, is less then 2.13.31.
The correct version is there. Either the detection is wrong or the triggered action is wrong. Try "hwinfo --sys" on the second console during the installation to check. If it detects the laptop formfactor then I guess the problem is with activating the proper selection/pattern -> jsrain. There the identity of the product that you are testing matters too.
hwinfo returns formfactor: laptop See attachment.
Created attachment 70667 [details] hwinfo --sys on Intel Development Laptop (no pcmcia)
This looks correctly. I added check to the same place in code where laptop was being checked, hope it helps. This fix will not be included in Beta6, but in following version.
in beta 7 it works now perfectly! thanks!