Bug 153962 - gal2-2.5.3-10: local variable used before set
Summary: gal2-2.5.3-10: local variable used before set
Status: RESOLVED FIXED
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Evolution (show other bugs)
Version: unspecified
Hardware: All SuSE Linux 10.1
: P5 - None : Normal
Target Milestone: ---
Assignee: Harish Krishnaswamy
QA Contact: Poornima Nayak
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-27 23:07 UTC by David Binderman
Modified: 2006-10-05 09:13 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2006-02-27 23:07:11 UTC 
I just tried to compile package gal2-2.5.3-10 with a pre release version 4.2
of the GNU C compiler.

It said

gal-view-new-dialog.c:259: warning: "entry" is used uninitialized in this function

The source code is

	if (entry && GTK_IS_ENTRY(entry)) {

I agree with the compiler. Suggest initialise local variable "entry" before
first use.
Comment 1 David Binderman 2006-05-16 21:41:03 UTC 
Still broken, some three months later, in the version that
ships in Suse Linux 10.1
Comment 2 Harish Krishnaswamy 2006-05-17 16:09:50 UTC 
Is it gal2 package that you are talking about ?
Gal was merged into Evolution during 2.4 (we have had two stable releases since) and we do not depend on/maintain this module anymore.

Not sure if somebody else uses this package anymore. If no, I suggest we drop it.

In gal-view-new-dialog.c in Evolution however, the variable 'entry' is initialized correctly.
Comment 3 Harish Krishnaswamy 2006-10-05 09:13:13 UTC 
David : per comment #2, I am resolving the bug fixed.