Bug 156966 - pixmp-2.6-1024: wrong return type on function ?
Summary: pixmp-2.6-1024: wrong return type on function ?
Status: RESOLVED FIXED
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: unspecified
Hardware: All SuSE Linux 10.1
: P5 - None : Normal
Target Milestone: ---
Assignee: Ladislav Michnovic
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-10 10:10 UTC by David Binderman
Modified: 2006-03-13 15:56 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2006-03-10 10:10:26 UTC 
I just tried to compile package pixmp-2.6-1024 with the GNU C compiler.

It said

1.

Draw.c:230: warning: "return" with no value, in function returning non-void
Draw.c:235: warning: "return" with no value, in function returning non-void

The source code is

        if (!(--dir->nEntries)) {
                return;
        }

        n = dir - &(SFdirs[SFdirPtr]);
        if ((n < 0) || (n > 2)) {
                return;


I agree with the compiler.  Suggest change return type of function from
"int" to "void".
Comment 1 Ladislav Michnovic 2006-03-13 15:16:32 UTC 
I will fix it. Thank you for reporting.
Comment 2 Ladislav Michnovic 2006-03-13 15:56:08 UTC 
Fixed, submited.