Bug 156968 - python-egenix-mx-base-2.0.6-9: dodgy code
Summary: python-egenix-mx-base-2.0.6-9: dodgy code
Status: RESOLVED FIXED
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: unspecified
Hardware: All SuSE Linux 10.1
: P5 - None : Normal
Target Milestone: ---
Assignee: Jan Matejek
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-10 10:15 UTC by David Binderman
Modified: 2006-03-13 16:29 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2006-03-10 10:15:06 UTC 
I just tried to compile package python-egenix-mx-base-2.0.6-9 with the GNU C compiler.

It said

mx/Tools/mxTools/mxTools.c:2136: warning: comparisons like X<=Y<=Z do not have their mathematical meaning

The source code is

	if (0 < number_len < sizeof(buffer)) {

Suggest code rework for maintainability.
Comment 1 Jan Matejek 2006-03-13 16:29:49 UTC 
fixed