CVE-2006-0745

https://bugs.freedesktop.org/show_bug.cgi?id=6213

I don't have access to this bugreport. :-(

"You are not authorized to access bug #6213." Maybe it's sufficient to add me to Cc of this bugreport?

I asked to add you...

Thanks. I'll notice when I've been added to this bugreport. :-)

Date: Fri, 10 Mar 2006 14:08:09 +0100
From: Matthieu Herrb <matthieu.herrb@laas.fr>
User-Agent: Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929)
To: vendor-sec@lst.de
Cc: xorg_security@x.org
Subject: [Xorg_security] X.Org 6.9/7.0 local root - found by coverity
Errors-To: xorg_security-bounces@x.org

Hi

Coverity scanned X.Org source code for problems and reported the results
to us. Among various minor problems, not security related, Alan
Coopersmith noticed that the problem #9482 is more serious, as it
provides a local root. The problem is illustrated by the patch below:

Index: xf86Init.c
===================================================================
RCS file: /cvs/xorg/xc/programs/Xserver/hw/xfree86/common/xf86Init.c,v
retrieving revision 1.29
diff -u -u -r1.29 xf86Init.c
--- xf86Init.c  14 Dec 2005 20:12:00 -0000      1.29
+++ xf86Init.c  10 Mar 2006 11:21:37 -0000
@@ -1376,7 +1376,7 @@
     }

   /* First the options that are only allowed for root */
-  if (getuid() == 0 || geteuid != 0)
+  if (getuid() == 0 || geteuid() != 0)
   {
     if (!strcmp(argv[i], "-modulepath"))
     {
@@ -1679,7 +1679,7 @@
   }
   if (!strcmp(argv[i], "-configure"))
   {
-    if (getuid() != 0 && geteuid == 0) {
+    if (getuid() != 0 && geteuid() == 0) {
        ErrorF("The '-configure' option can only be used by root.\n");
        exit(1);
     }

Since the address of geteuid() is always non NULL, both conditions are
always true. Thus any user can use the -modulepath, -logfile and
-configure options (which were supposed to be restricted to root).

The -modulepath option makes it possible to load arbitrary modules in
the Xserver that are later executed as root. The -logfile and -configure
options allow local DoS by overwriting any system file.

The vulnerable code was added to X.Org after 6.8.2 was released. So only
X.Org 6.9.0 and 7.0 are affected. No XFree86 version is affected.

This is the X.Org bug #6213 but this entry is marked confidential; only
members of the X.Org security team can access it. We propose to keep it
private until at least April 6th.

--
Matthieu Herrb

_______________________________________________
Xorg_security mailing list
Xorg_security@x.org
http://expo.x.org/mailman/listinfo/xorg_security

Thanks. That's enough information. When am I supposed to fix this problem for STABLE? 10.1 RC1 is scheduled for Fri, Mar 31, so this would be to early. :-(

The fix in stable should be released on the CRD.

Hm, for RC1 you can include the fix but omit the changelog entry, ok for you?

> The fix in stable should be released on the CRD.

CRD? Typo?

> Hm, for RC1 you can include the fix but omit the changelog entry, ok for 
> you?

Ok. I'll try.

Sorry.

CRD = Coordinated Release Date

fixed for Beta > 8.

is in 10.0 too, added by pc_x-noroot.diff 

Right. :-(

At least 9.3 and older is not affected.

Created attachment 72633 [details]
patchinfo

Thomas, I will need a SWAMPID for the 10.0 update.

Maintenance-Tracker-3775

Summary: Xorg: root hole in Xorg when installed setuid root
Issue was started by: thomas
Description:
This update of xorg-x11 fixes the incorrect checking of user privileges when it is installed setuid root. This allows local attackers to overwrite files or
even gain root privileges. (CVE-2006-0745)

Created attachment 72709 [details]
patchinfo

patchinfo file submitted.

--> /work/src/done/PATCHINFO/patchinfo.xorg-x11

Reassigning to Thomas for ACR (=A Coordinated Release).

Date: Wed, 15 Mar 2006 13:30:35 +0100
From: Matthieu Herrb <matthieu.herrb@laas.fr>
User-Agent: Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929)
To: vendor-sec@lst.de
Cc: xorg_security@x.org, Matthieu Herrb <matthieu.herrb@laas.fr>
Subject: [Xorg_security] Re: [vendor-sec] X.Org 6.9/7.0 local root - found
        by coverity
Errors-To: xorg_security-bounces@x.org

Matthieu Herrb wrote:
>Hi
>
>Coverity scanned X.Org source code for problems and reported the results
>to us. Among various minor problems, not security related, Alan
>Coopersmith noticed that the problem #9482 is more serious, as it
>provides a local root.
[...]

>
>This is the X.Org bug #6213 but this entry is marked confidential; only
>members of the X.Org security team can access it. We propose to keep it
>private until at least April 6th.
>

After discussion among X.Org security team (which has representative of
many vendors) it appears that not too many vendors already ship X.Org
6.9/7.0 (previous version are *not* affected) and that for many of them
an earlier disclosure date would be better.

Fedora project is going to release FC5 on March 20, but they'll start to
push the packages to their mirrors tomorrow, thurday 16. So this should
be considered as public starting at this date.

--
Matthieu Herrb

Changed CRD in swamp.

From: Matthieu Herrb <matthieu.herrb@laas.fr>
User-Agent: Mail/News  (X11/20060302)
To: xorg_security@x.org, vendor-sec@lst.de
Cc: Jesse Keating <jkeating@j2solutions.net>,
        Matthieu Herrb <matthieu.herrb@laas.fr>
Subject: Re: [vendor-sec] X.Org 6.9/7.0 local root - found by coverity
Errors-To: vendor-sec-admin@lst.de
Date: Thu, 16 Mar 2006 15:38:01 +0100

Jesse Keating wrote:
>On 03/15/2006 Matthieu Herrb wrote:
>
>>Fedora project is going to release FC5 on March 20, but they'll start to
>>push the packages to their mirrors tomorrow, thurday 16. So this should be
>>considered as public starting at this date.
>
>
>Thats actually not true.  We were hoping to, but we just didn't get
>enough communication in time.  We will be releasing this as a 0-day
>update for Fedora, but it will not make the shipping CDs.
>
So back to March 20, 14:00 UTC for the official disclosure, or did
someone already disclose it today?
_______________________________________________
Vendor Security mailing list
Vendor Security@lst.de
https://www.lst.de/cgi-bin/mailman/listinfo/vendor-sec

From: Daniel Stone <daniel@fooishbar.org>
To: xorg@lists.freedesktop.org
Cc: vendor-sec@lst.de, bugtraq@securityfocus.com
Mail-Followup-To: xorg@lists.freedesktop.org, vendor-sec@lst.de,
        bugtraq@securityfocus.com
User-Agent: Mutt/1.5.11
Subject: [vendor-sec] [CVE-2006-0745] X.Org Security Advisory: privilege escalation and DoS in X11R6.9, X11R7.0
Errors-To: vendor-sec-admin@lst.de
Date: Mon, 20 Mar 2006 16:00:58 +0200

[-- PGP Ausgabe folgt (aktuelle Zeit: Mo 20 MÀr 2006 15:10:35 CET) --]
gpg: Unterschrift vom Mo 20 MÀr 2006 15:00:58 CET, DSA SchlÌssel ID F2B1606C
gpg: Unterschrift kann nicht geprÃŒft werden: Ãffentlicher SchlÃŒssel nicht gefunden
[-- Ende der PGP-Ausgabe --]

[-- Die folgenden Daten sind signiert --]

X.Org Security Advisory, March 20th 2006
Local privilege escalation in X.Org server 1.0.0 and later; X11R6.9.0
and X11R7.0
CVE-ID: CVE-2006-0745


Overview:

During the analysis of results from the Coverity code review of X.Org,
we discovered a flaw in the server that allows local users to execute
arbitrary code with root privileges, or cause a denial of service by
overwriting files on the system, again with root privileges.


Vulnerability details:

When parsing arguments, the server takes care to check that only root
can pass the options -modulepath, which determines the location to load
many modules providing server functionality from, and -logfile, which
determines the location of the logfile.  Normally, these locations
cannot be changed by unprivileged users.

This test was changed to test the effective UID as well as the real UID
in X.Org.  The test is defective in that it tested the address of the
geteuid function, not the result of the function itself.  As a result,
given that the address of geteuid() is always non-zero, an unpriviliged
user can load modules from any location on the filesystem with root
privileges, or overwrite critical system files with the server log.


Affected versions:

xorg-server 1.0.0, as shipped with X11R7.0, and all release candidates
of X11R7.0, is vulnerable.
X11R6.9.0, and all release candidates, are vulnerable.
X11R6.8.2 and earlier versions are not vulnerable.

To check which version you have, run Xorg -version:
% Xorg -version
X Window System Version 7.0.0
Release Date: 21 December 2005
X Protocol Version 11, Revision 0, Release 7.0
[...]


Fix:

Apply the patch below to xorg-server-1.0.0 and 1.0.1 from the modular
X11R7 tree:
80db6a3ab76334061ec6102e74ef5607          xorg-server-1.0.1-geteuid.diff
44b44fa3efc63697eefadc7c2a1bfa50a35eec91  xorg-server-1.0.1-geteuid.diff
http://xorg.freedesktop.org/releases/X11R7.0/patches/

Alternately, xorg-server 1.0.2 has been released with this and other
code fixes:
5cd3316f07ed32a05cbd69e73a71bc74          xorg-server-1.0.2.tar.bz2
b2257e984c5111093ca80f1f63a7a9befa20b6c0  xorg-server-1.0.2.tar.bz2
f44f0f07136791ed7a4028bd0dd5eae3          xorg-server-1.0.2.tar.gz
3f5c98c31fe3ee51d63bb1ee9467b8c3fcaff5f3  xorg-server-1.0.2.tar.gz
http://xorg.freedesktop.org/releases/individual/xserver/

Apply the patch below to the X.Org server as distributed with X11R6.9:
de85e59b8906f76a52ec9162ec6c0b63          x11r6.9.0-geteuid.diff
f9b73b7c1bd7d6d6db6d23741d5d1125eea5f860  x11r6.9.0-geteuid.diff
http://xorg.freedesktop.org/releases/X11R6.9.0/patches/


Thanks:

We would like to thank Coverity for the use of their Prevent code audit
tool, which discovered this particular flaw.

[-- Ende der signierten Daten --]

packafes approved

CVE-2006-0745: CVSS v2 Base Score: 7.2 (AV:L/AC:L/Au:N/C:C/I:C/A:C)