Bug 158543 - hfs boot partition not recognized during bootloader config
Summary: hfs boot partition not recognized during bootloader config
Status: RESOLVED FIXED
: 154550 (view as bug list)
Alias: None
Product: SUSE Linux 10.1
Classification: openSUSE
Component: Installation (show other bugs)
Version: Beta 8
Hardware: Macintosh Linux
: P5 - None : Blocker (vote)
Target Milestone: ---
Assignee: Olaf Dabrunz
QA Contact: Klaus Kämpf
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-16 07:47 UTC by Olaf Hering
Modified: 2008-07-16 15:45 UTC (History)
0 users

See Also:
Found By: Development
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
bug158543.tar.bz2 (1.60 MB, application/x-bzip2)
2006-03-16 08:12 UTC, Olaf Hering
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Olaf Hering 2006-03-16 07:47:36 UTC
hda9 is a usable HFS bootpartition. But it is not selected per default.
as a result, boot= does not exist in the final lilo.conf
Comment 1 Olaf Hering 2006-03-16 07:49:09 UTC
great. and the y2logs dont exist. try again player one...
Comment 2 Olaf Hering 2006-03-16 08:12:32 UTC
Created attachment 73231 [details]
bug158543.tar.bz2
Comment 3 Joachim Plack 2006-03-23 11:12:48 UTC
still investigating
Comment 4 Olaf Hering 2006-04-11 13:39:58 UTC
no rc1 without a fix for this.
Comment 5 Joachim Plack 2006-04-11 15:04:29 UTC
Mmh, looks quite ok.

2006-03-15 14:44:07 <1> 1.1.1.1(2860) [YCP] bootloader/routines/lib_iface.ycp:206 Read global options: $["__exports__%global_options%activate":"bool:Change boot-device in NV-R
AM:true", "__exports__%global_options%append":"string:Append options for kernel command line", "__exports__%global_options%boot":"select:PPC Boot loader location:", "__exports
__%global_options%boot_pmac_custom":"select:HFS boot partition::/dev/hda9", "__exports__%global_options%bootfolder":"string:Bootfolder path:", "__exports__%global_options%defa
ult":"string:Default boot section:Linux", "__exports__%global_options%initrd":"path:Default initrd path", "__exports__%global_options%root":"select:Default root device:::/dev/
hda10:/dev/hda11", "__exports__%global_options%timeout":"int:Timeout in 1/10th seconds:50:0:600", "__exports__%section_options%image_append":"string:Optional kernel command li
ne parameter", "__exports__%section_options%image_copy":"bool:Copy image to boot partition:false", "__exports__%section_options%image_image":"path:Kernel image:/boot/vmlinux",
 "__exports__%section_options%image_initrd":"path:Initial RAM disk:/boot/initrd", "__exports__%section_options%image_root":"select:Root device::/dev/hda10:/dev/hda11", "__expo
rts__%section_options%other_other":"select:Boot partition of other system::", "__exports__%section_options%type_image":"bool:Kernel section", "__exports__%section_options%type
_other":"bool:Boot other system", "__exports__arch":"pmac", "lines_cache_id":"0"]
--------------
"root" can be any of( /dev/hda10, /dev/hda11 )
"boot" can be any of(  /dev/hda9 )

So all that´s left is doing a good proposal.

BTW: the selection for partitions is made the following way:

type == Apple_HFS|Apple_Bootstrap && size < 20 cyl   ==> boot
type == "Apple_HFS" and size_cyl >= 20 ==> root

cyl size is assumed to be around 8MB (the maximum)
Comment 6 Olaf Hering 2006-04-11 15:12:38 UTC
date.suse.de has an unrecognized boot partition, empty pulldown menu
Comment 7 Joachim Plack 2006-04-11 15:27:06 UTC
Well
y2log shows type 'unknown instead of Apple_Bootstrap:

$["boot":true, "detected_fs":`hfs, "device":"/dev/hda11", "format":true, "fsid":257, "fstype":"unknown", "name":"hda11", "nr":11, "regi
on":[2550, 8], "size_k":51200, "type":`primary, "udev_id":["ata-Maxtor_33073H3_B_L3HXJD1C-part11"], "udev_path":"pci-0.0001f000:ata-4-ide-0:0-part11", "used_fs":`hfs]

The problem might be in yast-storage:
    global list<string> not_shown_partitions = 
        [
        "Apple_partition_map",
        "Apple_Patches",
        "Apple_Driver",
        "Apple_Loader",
        "Apple_Boot",
        "Apple_Bootstrap",
        "Apple_FWDriver",
        "Apple_ProDOS" 
        ];


Comment 8 Olaf Hering 2006-04-11 15:28:57 UTC
that list is not referenced in the sources, but I will try to remove Apple_Bootstrap
Comment 9 Joachim Plack 2006-04-11 15:34:41 UTC
*** Bug 154550 has been marked as a duplicate of this bug. ***
Comment 10 Olaf Hering 2006-04-11 15:44:44 UTC
yes, changing this list doesnt seem to help. hda11 is not shown, even in the expert partitioner. where is the list of partitions to hide?
Comment 11 Olaf Hering 2006-04-11 15:47:41 UTC
I think its this code, Apple_Boot matches also Apple_Bootstrap. It may work better if HFS and UFS is probed first, and Apple_Bootstrap is handled explicit.

              if( id == Partition::ID_LINUX )
                  {
                  if( val.find( "Apple_partition" ) != string::npos ||
                      val.find( "Apple_Driver" ) != string::npos ||
                      val.find( "Apple_Loader" ) != string::npos ||
                      val.find( "Apple_Boot" ) != string::npos ||
                      val.find( "Apple_ProDOS" ) != string::npos ||
                      val.find( "Apple_FWDriver" ) != string::npos ||
                      val.find( "Apple_Patches" ) != string::npos )
                      {
                      id = Partition::ID_APPLE_OTHER;
                      }
                  else if( val.find( "Apple_HFS" ) != string::npos )
                      {
                      id = Partition::ID_APPLE_HFS;
                      }
                  else if( val.find( "Apple_UFS" ) != string::npos )
                      {
                      id = Partition::ID_APPLE_UFS;
                      }
                  }

./storage/libstorage/src/Disk.cc
Comment 12 Thomas Fehr 2006-04-11 15:49:54 UTC
The above code is relavent the one from ycp is obsolete.
Should I handle "Apple_Bootstrap" the same as "Apple_HFS"?
Comment 13 Olaf Hering 2006-04-11 15:53:49 UTC
yes, I think that is a good assumption. Since this partition in fact has a HFS filesystem, handling it like Apple_HFS makes sense.
Comment 14 Olaf Dabrunz 2006-04-11 16:01:28 UTC
Currently "Apple_HFS" has "fsid":258, "fstype":"Apple_HFS".

What is the "fsid" for "Apple_Bootstrap"?
Comment 15 Thomas Fehr 2006-04-11 16:06:17 UTC
There is no extra "fsid" for "Apple_Bootstrap".
I am about to change libstorage to handle "Apple_Bootstrap" like "Apple_HFS"
which means it will how up with is 258 and text "Apple_HFS" in expert partitioner.

Is this ok?
Comment 16 Olaf Hering 2006-04-11 16:08:46 UTC
yes, can you build me a lib for testing?
Comment 17 Olaf Dabrunz 2006-04-11 16:10:03 UTC
fehr@ comment #15: yes, fsid 258 is OK.
Comment 18 Thomas Fehr 2006-04-11 16:11:28 UTC
mbuild job Lagrange-fehr-2 is running if it is finished you can use it for
testing.
Comment 19 Olaf Hering 2006-04-11 16:33:17 UTC
yes, this version works, I replaced liby2storage.so
Comment 20 Clement Tiong 2006-04-11 17:07:07 UTC
My original defect was 154550. So, my question is still "Do we care about getting SLES10 PPC boot loader to work on G5 Mac?" I was told using G5 Mac for PPC testing is not really a valid hardware.

If we do want to get PPC boot loader to work on G5 Mac, then I will continue testing with it.
Comment 21 Clement Tiong 2006-04-11 17:16:28 UTC
Looking closer at the defect, this defect is for SuSE 10.1. So, the question is if PPC bootloader is supported in G5 Mac, is it supported for SLES10 since my defect#154550 for SLES10 is marked duplicated of this one?
Comment 22 Olaf Dabrunz 2006-04-11 19:04:07 UTC
The proposal for a bootloader device on pmac systems is fixed in
yast2-bootloader-2.13.44.
Comment 23 Olaf Dabrunz 2006-04-11 19:09:06 UTC
ctiong@: mfrueh should be able to answer your questions about supported
features.

Taking mfrueh to NEEDINFO.
Comment 24 Olaf Dabrunz 2006-04-11 20:24:32 UTC
Forgot to only use partitions with size < 20 cylinder.

Fix is in yast2-bootloader-2.13.45.
Comment 25 Olaf Dabrunz 2006-04-12 12:43:54 UTC
mfrueh told me that we want to have a working bootloader installation for
PPC on SL 10.1.