Bug 158757 - festival-1.95-18: undefined C code
Summary: festival-1.95-18: undefined C code
Status: RESOLVED FIXED
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: unspecified
Hardware: All SuSE Linux 10.1
: P5 - None : Minor
Target Milestone: ---
Assignee: Hendrik Vogelsang
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-16 18:43 UTC by David Binderman
Modified: 2006-03-21 15:32 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2006-03-16 18:43:34 UTC 
I just tried to compile package festival-1.95-18 with the GNU C compiler.

It said

rateconv.cc:387: warning: operation on "outidx" may be undefined

The source code is

            fir_stereo(inp + inoffset + inbaseidx,
                       coep + cycctr * firlen, firlen,
                       outp + outidx++, outp + outidx++);
 
I agree with the compiler.  Suggest new code

            fir_stereo(inp + inoffset + inbaseidx,
                       coep + cycctr * firlen, firlen,
                       outp + outidx, outp + outidx + 1);
		outidx += 2;
Comment 1 Hendrik Vogelsang 2006-03-21 15:32:54 UTC 
submitted.