DoneProvide is called when an object is downloaded (error should be zero in this case). Zypp doesn't allow to pass a result, returned value from yast is ignored.

I enhanced pkg-bindings in SVN to call DoneProvide callback when a problem occurr during download (error argument should be non-zero), the return value of the callback ("C" = ABORT, "R" = RETRY) is passed to zypp.

To abort during download use ProgressProvide callback.

Please test it and provide feedback.

I do not know how to check the failure of download, so I just removed the check for user input in DoneProvide and DonePackage.

Use the error argument of the callback handler (the first argument), zero value means finished without problem, non-zero means an error occurred during download (the return value from the callback is passed to zypp in this case).

Is it OK? How can I help you?

I know, I mean I am not able to reach the real failure (so the error would be non-zero).

Fixed in pkg-bindings-2.13.43

If it still doesn't work properly then reopen...

OK, so now I'm using CallbackProgressProvide and CallbackProgressPackage, but when I return false for these functions (which should mean abort), nothing happens.

So, this is for Stano...

The download progress callbacks should return true if they are going to be aborted.

CallbackProgressProvide and Pkg::CallbackProgressPackage are mapped to OnlineUpdateCallbacks::PatchProgressCallback, which returns false only if user clicks abort or cancel, otherwise it returs true. The update process never aborts.

Looks like download progress callback does not work as it should.

Of course it does not work, because it is never invoked.

Fixed in rev. 3007

*** Bug 116386 has been marked as a duplicate of this bug. ***