Bug 166920 - jrwlap kernel: Asus ACPI: Error reading LCD status
Summary: jrwlap kernel: Asus ACPI: Error reading LCD status
Status: RESOLVED FIXED
: 166923 (view as bug list)
Alias: None
Product: SUSE Linux 10.1
Classification: openSUSE
Component: Kernel (show other bugs)
Version: RC 1
Hardware: 32bit SuSE Linux 10.1
: P5 - None : Critical (vote)
Target Milestone: ---
Assignee: Thomas Renninger
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-15 13:52 UTC by Jerry Westrick
Modified: 2006-04-25 07:50 UTC (History)
3 users (show)

See Also:
Found By: Beta-Customer
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
Requested ACPIDUMP output (70.45 KB, text/plain)
2006-04-22 13:05 UTC, Jerry Westrick
Details
ASUS ACPI: Refuse to load unknown systems. (788 bytes, patch)
2006-04-23 12:58 UTC, Timo Hoenig
Details | Diff
Also add a "force=1" module parameter to be able to support not listed models that did run before (1.91 KB, patch)
2006-04-24 16:32 UTC, Thomas Renninger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jerry Westrick 2006-04-15 13:52:06 UTC
After Installing 10.1 RC1 on a Sony VAIO VGN-A197VP laptop
the module asus_acpi is loaded.  This module fills the /var/log/message with 
messages as follows:

Apr 15 15:31:23 jrwlap kernel: Asus ACPI: Error reading LCD status
Apr 15 15:31:23 jrwlap kernel: Asus ACPI: Error reading LCD status
Apr 15 15:31:23 jrwlap kernel: Asus ACPI: Error reading brightness
Apr 15 15:31:23 jrwlap kernel: Asus ACPI: Error reading brightness
Apr 15 15:31:23 jrwlap kernel: Asus ACPI: Error reading LCD status
Apr 15 15:31:23 jrwlap kernel: Asus ACPI: Error reading LCD status
Apr 15 15:31:23 jrwlap kernel: Asus ACPI: Error reading brightness
Apr 15 15:31:23 jrwlap kernel: Asus ACPI: Error reading brightness
Apr 15 15:31:23 jrwlap kernel: Asus ACPI: Error reading LCD status
Apr 15 15:31:23 jrwlap kernel: Asus ACPI: Error reading LCD status

Additionally I get "OSD" messages "LCD Brightness set..." and such
until I remove the module with: "rmmod asus_acpi" (as root)

I've not tested the what function may be missing by removing the module...
Additionally, the sony_acpi is load also....

Here the output of lsmod:

Module                  Size  Used by
xt_pkttype              1792  5 
ipt_LOG                 5632  10 
xt_limit                2432  10 
af_packet              19336  2 
cpufreq_ondemand        5660  1 
cpufreq_userspace       3732  0 
cpufreq_powersave       1792  0 
speedstep_centrino      6736  1 
freq_table              4228  1 speedstep_centrino
snd_pcm_oss            42752  0 
snd_mixer_oss          16512  1 snd_pcm_oss
snd_seq                47216  0 
snd_seq_device          7948  1 snd_seq
edd                     8516  0 
sony_acpi               5388  0 
button                  6672  0 
battery                 9476  0 
ac                      4996  0 
ip6t_REJECT             4992  3 
xt_tcpudp               3072  11 
ipt_REJECT              5120  3 
xt_state                2048  12 
iptable_mangle          2688  0 
iptable_nat             7684  0 
ip_nat                 15660  1 iptable_nat
iptable_filter          2816  1 
ip6table_mangle         2304  0 
ip_conntrack           47916  3 xt_state,iptable_nat,ip_nat
nfnetlink               6168  2 ip_nat,ip_conntrack
ip_tables              11080  3 iptable_mangle,iptable_nat,iptable_filter
ip6table_filter         2688  1 
ip6_tables             12360  2 ip6table_mangle,ip6table_filter
x_tables               11908  10 xt_pkttype,ipt_LOG,xt_limit,ip6t_REJECT,xt_tcpudp,ipt_REJECT,xt_state,iptable_nat,ip_tables,ip6_tables
ipv6                  215680  13 ip6t_REJECT
apparmor               46876  0 
aamatch_pcre           13440  1 apparmor
loop                   14728  0 
dm_mod                 52328  0 
rfcomm                 32408  0 
hidp                   15360  2 
l2cap                  20740  10 rfcomm,hidp
hci_usb                13588  2 
bluetooth              41188  8 rfcomm,hidp,l2cap,hci_usb
usbhid                 39392  0 
pcmcia                 34492  0 
ipw2200                92980  0 
ieee80211              28232  1 ipw2200
ieee80211_crypt         5248  1 ieee80211
firmware_class          9856  2 pcmcia,ipw2200
snd_intel8x0           30236  3 
snd_ac97_codec         82848  1 snd_intel8x0
snd_ac97_bus            2176  1 snd_ac97_codec
snd_pcm                80136  4 snd_pcm_oss,snd_intel8x0,snd_ac97_codec
snd_timer              20868  3 snd_seq,snd_pcm
snd                    51076  12 snd_pcm_oss,snd_mixer_oss,snd_seq,snd_seq_device,snd_intel8x0,snd_ac97_codec,snd_pcm,snd_timer
soundcore               8672  1 snd
e1000                 102072  0 
i2c_i801                7948  0 
ide_cd                 35488  0 
snd_page_alloc          9608  2 snd_intel8x0,snd_pcm
i2c_core               19728  1 i2c_i801
shpchp                 39488  0 
pci_hotplug            24372  1 shpchp
cdrom                  32416  1 ide_cd
intel_agp              21020  1 
agpgart                28976  1 intel_agp
yenta_socket           23692  1 
rsrc_nonstatic         12416  1 yenta_socket
pcmcia_core            37008  3 pcmcia,yenta_socket,rsrc_nonstatic
uhci_hcd               27280  0 
ohci1394               29360  0 
ieee1394               87992  1 ohci1394
ohci_hcd               17284  0 
ehci_hcd               26760  0 
usbcore               109700  6 hci_usb,usbhid,uhci_hcd,ohci_hcd,ehci_hcd
reiserfs              210944  2 
fan                     4612  0 
thermal                13448  0 
processor              22592  2 speedstep_centrino,thermal
piix                    9092  0 [permanent]
ide_disk               15104  4 
ide_core              119740  3 ide_cd,piix,ide_disk

I don't know when the sony_acpi is loaded, but if it's only for sony_laptops then maybe a quick check to see if sony in loaded before loading the asus_acpi module?

Jerry Westrick.
Comment 1 Greg Kroah-Hartman 2006-04-16 17:07:01 UTC
*** Bug 166923 has been marked as a duplicate of this bug. ***
Comment 2 Thomas Renninger 2006-04-22 01:14:18 UTC
Could you please attach acpidump output.
It seems as if your DSDT table has a device with HID: ATK0100 (Asus) and a device with HID SNY5001 (Sony).
If this is really the case the "Test all ACPI vendor modules until we find the appropriate" approach does not work anymore...

Timo, maybe we should really add an additional vendor check before loading these?
something like is_laptop && vendor_matches, I could imagine in this case we could even ignore the "is tainting SLES kernel" case as SLES+laptop is probably rare. But for this we need PM approval.

Let's see what acpidump is telling us...
Comment 3 Jerry Westrick 2006-04-22 13:05:25 UTC
Created attachment 79563 [details]
Requested ACPIDUMP output
Comment 4 Timo Hoenig 2006-04-23 10:47:42 UTC
(In reply to comment #1)

> ***  Bug 166923 has been marked as a duplicate of this bug. ***

Pang, wrt bug #166923, please let me know whether it was a ASUS laptop or some other system. Thanks!
Comment 5 Timo Hoenig 2006-04-23 11:08:30 UTC
Thomas, I totally agree, its a very bad thing that ATK0100 shows up...

I'm working on a patch that ASUS ACPI will only load on supported systems.  This means that it will only load on systems which

(a) have ATK0100
and
(b) are known to the driver (a static configuration has to be present in the model_conf struct).

As I understand the code, currently the driver loads on all systems which have ATK0100 in their DSDT and if there is no static configuration in model_conf it simply defaults to the model M2E.

With the upcoming patch we should be safe, the driver only loads on supported systems.
Comment 6 Timo Hoenig 2006-04-23 12:58:07 UTC
Created attachment 79585 [details]
ASUS ACPI: Refuse to load unknown systems.

Thomas, please review and apply if appropriate.

Note:  The patch is only compile-tested.
Comment 7 Thomas Renninger 2006-04-24 16:32:10 UTC
Created attachment 79727 [details]
Also add a "force=1" module parameter to be able to support not listed models that did run before
Comment 8 Thomas Renninger 2006-04-24 16:36:51 UTC
I will now commit this to HEAD.
Timo says (and I think he is right), we should also add this into 10.1 branch.
We expect all (at least more coming up) Sony laptops that also have the asus ACPI hotkey device.

However, we need approval for this ....
Comment 9 Andreas Jaeger 2006-04-24 16:58:29 UTC
go ahead for 10.1
Comment 10 Thomas Renninger 2006-04-25 07:44:55 UTC
done.
Comment 11 Timo Hoenig 2006-04-25 07:50:06 UTC
Thank you!