Bug 192080 - uninitalized disk gets an msdos partition table on pmac
Summary: uninitalized disk gets an msdos partition table on pmac
Status: RESOLVED FIXED
Alias: None
Product: openSUSE 10.2
Classification: openSUSE
Component: Installation (show other bugs)
Version: Alpha 1
Hardware: PowerPC Linux
: P5 - None : Major (vote)
Target Milestone: Alpha 3
Assignee: Thomas Fehr
QA Contact: Stanislav Visnovsky
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-13 09:32 UTC by Olaf Hering
Modified: 2008-07-16 15:43 UTC (History)
0 users

See Also:
Found By: Development
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
bug192080.tar.bz2 (245.67 KB, application/x-bzip2)
2006-07-13 09:34 UTC, Olaf Hering
Details
bug192080.tar.bz2 (46.19 KB, application/x-bzip2)
2006-07-27 09:57 UTC, Olaf Hering
Details
bug192080.tar.bz2 (46.26 KB, application/x-bzip2)
2006-08-01 11:15 UTC, Olaf Hering
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Olaf Hering 2006-07-13 09:32:02 UTC
run these commands on apple.suse.de

dd if=/dev/zero of=/dev/sda bs=1M count=1
blockdev --rereadpt /dev/sda
yast

the partitioner suggests an extended partition, which makes me think it will create an partition table of type 'msdos' instead of 'mac'.
While Linux may have no problem accessing the disk, the firmware can not handle it.
Comment 1 Olaf Hering 2006-07-13 09:34:28 UTC
Created attachment 93389 [details]
bug192080.tar.bz2
Comment 2 Olaf Hering 2006-07-13 09:37:31 UTC
if I create a mac label in the background and let yast reread the partition table in the expert partitioner, then go one window back and choose 'sda whole disk', the proposal looks correct.
Comment 3 Michal Zugec 2006-07-13 11:00:44 UTC
Thomas, could you look at this problem?
Comment 4 Thomas Fehr 2006-07-13 11:17:19 UTC
So far default disk label is determined by processor architecture.
It is "gpt" for IA64, "sun" for "sparc" and "msdos" otherwise.

Of course I could extend this to create a mac disk label for arch PPC but I 
doubt this would be useful since there are many different PPC machines. 
Need exact specifiction under which circumstances a mac disk label should be
created.
Comment 5 Olaf Hering 2006-07-13 12:18:05 UTC
yast2/library/modules/Arch.ycp provides Arch::board_mac to test this condition.
Comment 6 Olaf Hering 2006-07-13 12:24:15 UTC
./storage/storage/src/modules/Partitions.ycp has DefaultPartLabel(), but there is also ./storage/libstorage/src/Disk.cc.
Comment 7 Olaf Hering 2006-07-13 13:50:11 UTC
as discussed, the c++ code is used. in /proc/cpuinfo, the line 
^machine contains either "PowerMac*" or "PowerBook*"
Comment 8 Thomas Fehr 2006-07-13 14:31:16 UTC
Should be fixed in current svn head.
Comment 9 Olaf Hering 2006-07-17 06:02:41 UTC
on an empty disk without disk label, yast will start create partitions with sda1
on an empty disk with mac disk label, yast will start create partitions with sda2
sda1 is the partition table. There seems to be some check for that fact. It has to be applied also for a disk without disk label.
Comment 10 Thomas Fehr 2006-07-24 13:17:24 UTC
Should be fixed in SVN head for SL 10.2.
Comment 11 Olaf Hering 2006-07-27 09:57:21 UTC
r31968 doesnt seem to fix it. sda1 is supposed to be created, with 20.0GB.

I have replaced these files:

usr/lib/YaST2/plugin/libpy2StorageCallbacks.so.2.0.0
usr/lib/perl5/vendor_perl/5.8.8/ppc-linux-thread-multi-64int/LibStorage.so
usr/lib/liby2storage.so.2.0.0
Comment 12 Olaf Hering 2006-07-27 09:57:50 UTC
Created attachment 94622 [details]
bug192080.tar.bz2
Comment 13 Thomas Fehr 2006-07-27 10:23:33 UTC
Current DVN head of do_proposal_flexible.ycp should fix that.
Comment 14 Olaf Hering 2006-07-27 11:05:50 UTC
no, still sda1 20.0GB.
Now the proposal doesnt seem to assign mount points to the partitions, r32019 doesnt help.

system is mac.suse.de, root pwd is 'root'.
Comment 15 Thomas Fehr 2006-07-27 14:43:41 UTC
Current SVN head should heopefully finally work (unfirtuanately
mac.suse.de froze again while testing).
Comment 16 Olaf Hering 2006-08-01 11:14:10 UTC
its still not perfect.
sda2 is now the root partition, but its way too small with 39.2MB.
Comment 17 Olaf Hering 2006-08-01 11:15:13 UTC
Created attachment 94893 [details]
bug192080.tar.bz2
Comment 18 Thomas Fehr 2006-08-01 11:38:57 UTC
Did you test with the new version of do_proposal_flexible.ycp I mentioned
in comment#13? From the logs it does not look so.
Comment 19 Olaf Hering 2006-08-01 12:25:12 UTC
yes, I forgot that add this file to my inst-sys.
hopefully the swig bindings get fixed soon.