Bug 204719 - inkscape is missing icons
Summary: inkscape is missing icons
Status: RESOLVED FIXED
: 207430 (view as bug list)
Alias: None
Product: openSUSE 10.2
Classification: openSUSE
Component: GNOME (show other bugs)
Version: Alpha 4
Hardware: Other Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Joe Hargadon
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-09 10:10 UTC by Daniel Molkentin
Modified: 2006-10-26 15:15 UTC (History)
1 user (show)

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
Error output listing missing icons on startup (3.37 KB, text/x-log)
2006-09-09 10:11 UTC, Daniel Molkentin
Details
Patch (2.51 KB, patch)
2006-10-06 00:31 UTC, Andreas Hanke
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Molkentin 2006-09-09 10:10:05 UTC
When using inkscape from Beta 4 or factory, several icons are missing, at least when KDE is selected as default desktop. This is either a packaging bug or a missing dependency. 

Version information:

# rpm -qi inkscape
Name        : inkscape                     Relocations: (not relocatable)
Version     : 0.43                              Vendor: SUSE LINUX Products GmbH, Nuernberg, Germany

Output of missing icons (stderr log) attached.
Comment 1 Daniel Molkentin 2006-09-09 10:11:02 UTC
Created attachment 98274 [details]
Error output listing missing icons on startup
Comment 2 Daniel Molkentin 2006-09-09 10:25:21 UTC
Sorry, that should of course read Alpha 4
Comment 3 JP Rosevear 2006-09-13 03:17:08 UTC
Does running SuSEconfig solve the problem?
Comment 4 Daniel Molkentin 2006-09-13 05:47:03 UTC
Nope, Problem presists. The icons don't appear to be part of the package either, at least not as seperate files. Are they compiled into some resource file?
Comment 5 Daniel Molkentin 2006-09-13 09:18:58 UTC
Information provided.
Comment 6 JP Rosevear 2006-09-18 16:05:15 UTC
They are likely part of the icon theme.  Is gnome-icon-theme and/or tango-icon-theme installed?
Comment 7 Daniel Molkentin 2006-09-18 17:34:54 UTC
yes:

tango-icon-theme-0.7.2-12
gnome-icon-theme-2.15.92-4

Both were not auto-dependencies of inkscape, though. They got installed later.
Comment 8 Stephan Binner 2006-09-23 11:37:51 UTC
*** Bug 207430 has been marked as a duplicate of this bug. ***
Comment 9 JP Rosevear 2006-09-26 18:20:32 UTC
This looks like either a build issue or a corrupt package since:

** (process:26407): WARNING **: Could not open units file '${datarootdir}/inkscape/ui/units.txt': No such file or directory

indicates it can't find other items as well (and rpm -ql inkscape | grep units.txt shows a file for me).  Works fine under both GNOME and KDE for me (both installed).

Comment 10 Andreas Hanke 2006-09-26 21:45:19 UTC
${datarootdir} is an unexpanded autotools variable, indicating a build system bug in inkscape.

It seems to be fixed by now, "strings" does not find any occurances of "datarootdir" in /opt/gnome/bin/inkscape. Instead, it finds an occurance of

/opt/gnome/share/inkscape/ui

which indicates that the underlying problem is fixed by now.
Comment 11 Andreas Hanke 2006-09-26 22:47:08 UTC
Sorry, I really managed to confuse my 10.1 and 10.2 systems. Comment 10 is wrong because of that, please ignore it. => Reopening.

inkscape is still broken, there are unexpanded autotools variables all over the place:

% strings /opt/gnome/bin/inkscape | grep datarootdir
${datarootdir}/inkscape/extensions
${datarootdir}/pixmaps
${datarootdir}/locale
${datarootdir}/inkscape/templates
${datarootdir}/inkscape/screens
${datarootdir}/inkscape/tutorials
${datarootdir}/inkscape/markers
${datarootdir}/inkscape/palettes
${datarootdir}/inkscape/icons
${datarootdir}/inkscape/gradients
${datarootdir}/inkscape/patterns
${datarootdir}/inkscape/ui
${datarootdir}

That way the binary will not be able to find any of its resources.

(It's caused by autoconf 2.60, it expands ${datadir} to ${datarootdir} by default which did not exist in earlier autoconf versions. This requires build scripts to be adjusted.)
Comment 12 Andreas Hanke 2006-09-26 23:18:50 UTC
The bug is in inkscape's configure.ac between lines 706 and 728: The test does not handle ${datarootdir} at all.

Known upstream:

http://sourceforge.net/search/?ml_name=inkscape-devel&type_of_search=mlists&group_id=93438&words=datarootdir

https://sourceforge.net/tracker/?func=detail&atid=604308&aid=1521963&group_id=93438

But none of the three patches is good, they are all removing the bad code instead of fixing it.
Comment 13 Andreas Hanke 2006-09-27 00:36:10 UTC
It's totally broken, the default config.h when just running ./configure without arguments contains:

#define INKSCAPE_DATADIR "${datarootdir}"
#define INKSCAPE_LIBDIR "NONE/lib"
#define PACKAGE_LOCALE_DIR "${datarootdir}/locale"

Any volunteers to fix this for autoconf 2.60 without breaking it for earlier autoconf versions? If not, you can work around this bug by explicitly adding

--datadir=/opt/gnome/share

to the ./configure invocation. It's not a fix, but prevents the buggy code path from being used.
Comment 14 JP Rosevear 2006-09-27 14:30:17 UTC
I'm puzzled why I can't replicate this on alpha4.
Comment 15 Joe Hargadon 2006-10-04 20:26:29 UTC
Should I go ahead and add --datadir=/opt/gnome/share to the ./configure for the time being?
Comment 16 Andreas Hanke 2006-10-05 15:42:35 UTC
"strings" shows that the latest Factory build (inkscape-0.44.1-2) still has ${datarootdir} compiled into the binary. (Unfortunately it's not installable because of bug 209601.)

So I'd say "Yes". A workaround is better than a broken inkscape.
Comment 17 Joe Hargadon 2006-10-05 16:17:06 UTC
I have submitted inkscape with the --datadir=/opt/gnome/share workaround.
Comment 18 Andreas Hanke 2006-10-06 00:31:26 UTC
Created attachment 100635 [details]
Patch

This should be a real fix.

But I recommend keeping just the workaround for now and not using this patch. The patch doesn't fix binreloc detection (broken as well for the same reason, but unused on Linux) - I'll try to fix that as well and submit the patch upstream.
Comment 19 Dominik Jais 2006-10-09 14:01:35 UTC
still missing in alpha5
Comment 20 JP Rosevear 2006-10-26 15:15:37 UTC
Since we have a workaround, Andreas I would say you should just file your fix upstream and we'll close this out for 10.2.