Bug 224216 - reproducable crash in libzypp (uncaught checksum exception)
Summary: reproducable crash in libzypp (uncaught checksum exception)
Status: RESOLVED FIXED
: 173291 237595 (view as bug list)
Alias: None
Product: openSUSE 10.2
Classification: openSUSE
Component: YaST2 (show other bugs)
Version: RC 2
Hardware: Other Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Jan Kupec
QA Contact: Jiri Srain
URL:
Whiteboard:
Keywords:
Depends on: 217425
Blocks:
  Show dependency treegraph
 
Reported: 2006-11-28 17:43 UTC by Marcus Rückert
Modified: 2007-05-22 09:31 UTC (History)
4 users (show)

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
console output (55.76 KB, text/plain)
2006-11-28 17:43 UTC, Marcus Rückert
Details
gdb output (20.98 KB, text/plain)
2006-11-28 17:44 UTC, Marcus Rückert
Details
proposed patch (780 bytes, patch)
2007-01-23 17:50 UTC, Duncan Mac-Vicar
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus Rückert 2006-11-28 17:43:16 UTC
"zypper update -t package -y"

you can try it on hydrogen. i wont change the installation. attached is the output from 

"zypper update -t package -y 2>&1 | tee zypper.console.log"
and the gdb stack traces. the core file is still in the root home
Comment 1 Marcus Rückert 2006-11-28 17:43:41 UTC
Created attachment 107258 [details]
console output
Comment 2 Marcus Rückert 2006-11-28 17:44:02 UTC
Created attachment 107259 [details]
gdb output
Comment 3 Martin Vidner 2006-11-29 11:18:28 UTC
End of comment 1:
(aborting)
terminate called after throwing an instance of 'zypp::Exception'
  what():  File /var/adm/mount/AP_0x00000005/suse/noarch/Crystalcursors-0.5-62.noarch.rpm fails integrity check. Expected: [sha1-89fb0e2bf8181d6d016b5b0e36e2d25acaf87a37] Got: [sha1-353f97df52a501caafd5671caa89d7d7329eb8e5]

It is an uncaught exception, a bug in zypper as the user of libzypp.
Comment 4 Jan Kupec 2006-12-18 09:31:35 UTC
The exception (thrown in source::provideFile()) should be a specialized one (e.g. zypp::source::FailedChecksumException), otherwise we need to catch general Exception in zypper (or yast) and see if its msg().find("fails integrity check") != npos (which is an ugly hack), if we want to avoid the ugly output.

Anyway, this is what i have to do, if we want the bug fixed for YOU, but for 10.3, it should be fixed correctly, what do you think?
Comment 5 Jan Kupec 2007-01-23 08:42:22 UTC
*** Bug 237595 has been marked as a duplicate of this bug. ***
Comment 6 Jan Kupec 2007-01-23 09:04:44 UTC
The ProvideFilePolicy::failOnChecksumErrorCB() used to prompt the user for action (abort/retry/ignore) after failed integrity check needs to be fixed in order to fix this bug (bug #217425)

The new special exception mentioned in comment #4 is needed e.g. to properly implement display of explanatory message in case of abort.
Comment 7 Duncan Mac-Vicar 2007-01-23 17:50:55 UTC
Created attachment 114499 [details]
proposed patch
Comment 8 Jan Kupec 2007-01-23 18:44:52 UTC
(In reply to comment #7)
> Created an attachment (id=114499) [edit]
> proposed patch

Wow. I didn't expect it to be so easy. Seems it works :O)

$ zypper in kvpnc freeglut krusader
Restoring system sources...
Parsing metadata for factory-non-oss...
Parsing metadata for packman10.2...
Parsing metadata for factory...
Parsing RPM database...
Summary:
<install>   [S3:1][package]krusader-1.70.1-44.x86_64
<install>   [S3:1][package]freeglut-060903-28.x86_64
<install>   [S3:1][package]kvpnc-0.8.7-12.x86_64
<uninstall> [S0:0][package]krusader-1.70.1-32.x86_64
Continue? [y/n] y
Downloading: [S3:1][package]krusader-1.70.1-44.x86_64, 2.2 M(5.9 M unpacked)
Installing: [S3:1][package]krusader-1.70.1-44.x86_64
Downloading: [S3:1][package]freeglut-060903-28.x86_64, 107.6 K(333.4 K unpacked)
Package freeglut-060903-28 fails integrity check. Do you want to retry downloading it?
(A)bort, (R)etry, (I)gnore?
i
Downloading: [S3:1][package]kvpnc-0.8.7-12.x86_64, 1.6 M(3.7 M unpacked)
Installing: [S3:1][package]kvpnc-0.8.7-12.x86_64

What's remaining is a test of the patch in installation (for bug #217425), but i bet it'll work.
Comment 9 Duncan Mac-Vicar 2007-01-24 14:10:52 UTC

*** This bug has been marked as a duplicate of bug 217425 ***
Comment 10 Jan Kupec 2007-01-25 08:13:10 UTC
This bug is not a dup of bug 217425 it just depends on it and is related only to zypper not libzypp. It needs some work yet, only an explanatory message is shown for now.
Comment 11 Anja Stock 2007-01-25 11:27:39 UTC
released
Comment 12 Duncan Mac-Vicar 2007-05-22 09:31:49 UTC
*** Bug 173291 has been marked as a duplicate of this bug. ***