Bugzilla – Bug 293039
libzypp: Broken calculation of installing RPM size
Last modified: 2007-08-30 14:41:31 UTC
Created attachment 151884 [details] screenshot The installation summary and thermometer in YaST2 sw_single shows 0 size of RPMs which will be installed. Some of RPMs were selected of course. ;)
Created attachment 151885 [details] yast2 logs
Libzypp doesn't support disk usage counting (needs to be reimplemented after refactoring).
Increasing severity, regression.
*** Bug 297566 has been marked as a duplicate of this bug. ***
The problem is in Beta 1 also.
*** Bug 299185 has been marked as a duplicate of this bug. ***
*** Bug 299405 has been marked as a duplicate of this bug. ***
*** Bug 298947 has been marked as a duplicate of this bug. ***
I just tested with Stefan the UI with 3.18.4 and it works. We also confirmed that in 3.18.2 it was not working. So this is the milestone version: ------------------------------------------------------------------- Tue Aug 21 13:06:44 CEST 2007 - dmacvicar@suse.de - If no mount information is available, parse all DU entries.
Ok, to make sure it will work in installation. If disk partition is set manually to ZYpp, then that will be used for parsing. If it is not set, they will be detected (or try to) After that, if the partitions are empty (either by manual set, or because no detection results) everything in packages.DU is taken into account. If it is not empty (running system) only needed paths are taken into account. I just need to verify that DiskUsageCounter::detectPartitions() gives a empty result before YaST set the partitions. Ladislav?
DiskUsageCounter::detectMountPoints() reads the current partitioning from the system, it's called from Pkg::SetCurrentDU() (an internal helper, not available from YCP). It always return non-empty result (unless the system doesn't have any mounted partition). SetCurrentDU() is used in Pkg::TargetInitDU() when the parameter map is empty or in Pkg::TargetGetDU() when the partitioning hasn't been set. According my install log the first call durin installation sets the partitioning so SetCurrentDU() shouldn't be called during installation: 2007-08-27 08:34:58 <1> 10.20.1.7(3492) [wfm] clients/wrapper_storage.ycp:367 Pkg Builtin called: TargetInitDU 2007-08-27 08:34:58 <1> 10.20.1.7(3492) [wfm] Target.cc(TargetInitDU):623 Adding / 2007-08-27 08:34:58 <1> 10.20.1.7(3492) [wfm] Target.cc(TargetInitDU):623 Adding home I think you probably mean ZYpp::getPartitions() - yes, it returns empty partitioning until it's set by Yast.
Space is provided fine by plaindir, verified.
package size works in installation. small issue with initialized pointer fixed in last submssion.
closing