Bug 308641 - Pixelated icons in YaST navigation (left pane)
Summary: Pixelated icons in YaST navigation (left pane)
Status: RESOLVED FIXED
Alias: None
Product: openSUSE 10.3
Classification: openSUSE
Component: YaST2 (show other bugs)
Version: Beta 3
Hardware: Other Other
: P5 - None : Minor (vote)
Target Milestone: ---
Assignee: Thomas Göttlicher
QA Contact: Jiri Srain
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-07 13:58 UTC by Francis Giannaros
Modified: 2007-10-24 09:54 UTC (History)
0 users

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
pixelated yast icons in left pane (48.50 KB, image/png)
2007-09-07 13:58 UTC, Francis Giannaros 		Details
patch (945 bytes, patch)
2007-09-20 09:45 UTC, Thomas Göttlicher 		Details | Diff
patch (1.29 KB, text/x-patch)
2007-09-21 14:27 UTC, Thomas Göttlicher 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Francis Giannaros 2007-09-07 13:58:23 UTC 
Created attachment 162738 [details]
pixelated yast icons in left pane

In the navigation some of the icons appear pixelated (see attachment below),
though on the right they appear perfectly clear and fine.
Comment 1 Francis Giannaros 2007-09-14 11:36:53 UTC 
This issue is still here in beta3plus, and it really makes things look ugly. Will this be fixed in time?
Comment 2 Thomas Göttlicher 2007-09-20 09:45:47 UTC 
Created attachment 173602 [details]
patch

This bug is caused by scaling the icons.

I will submit the attached patch to svn after 10.3.
Comment 3 Stefan Hundhammer 2007-09-20 11:56:17 UTC 
AFAICS this patch undoes the change necessary for bug #295712: Add a one-pixel border around the icons. The "trivial change" dmueller mentioned in that bug turned out to be not trivial at all; the result is the code your patch throws out. Basically, that code creates a new pixmap one pixel larger than the original icon and then copies the icon's pixels and the icons's bit mask into the larger icon with border. But something may be slightly wrong there.
Comment 4 Thomas Göttlicher 2007-09-21 14:25:35 UTC 
Thanks for that hint.

I have found out the real problem: The adapted mask is 1-bpp. Therefore the alpha-gradients are destroyed and icons appear pixelated.
Comment 5 Thomas Göttlicher 2007-09-21 14:27:12 UTC 
Created attachment 173908 [details]
patch
Comment 6 Thomas Göttlicher 2007-10-24 09:53:55 UTC 
Fixed in svn r41537.
Comment 7 Thomas Göttlicher 2007-10-24 09:54:23 UTC 
Submitted to STABLE.