Bug 309058 - Main-Menu "Places" Items have no "Remove from Favorites"
Summary: Main-Menu "Places" Items have no "Remove from Favorites"
Status: RESOLVED NORESPONSE
Alias: None
Product: openSUSE 11.0
Classification: openSUSE
Component: GNOME (show other bugs)
Version: Beta 2
Hardware: Other Other
: P3 - Medium : Normal (vote)
Target Milestone: ---
Assignee: Federico Mena Quintero
QA Contact: E-mail List
URL:
Whiteboard: gnomeup-gnome-main-menu, gnome-usability
Keywords:
Depends on:
Blocks: main-menu-behavior
  Show dependency tree / graph
 
Reported: 2007-09-09 16:09 UTC by Stephan Binner
Modified: 2011-04-04 03:45 UTC (History)
6 users (show)

See Also:
Found By: Development
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Proposed solution (17.29 KB, patch)
2007-12-19 23:17 UTC, Lukas Lipka 		Details | Diff
Proposed solution (30.69 KB, patch)
2007-12-23 11:06 UTC, Lukas Lipka 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Binner 2007-09-09 16:09:03 UTC 
Items in the GNOME main menu's "Places" tab have no context menu item "Remove from Favorites" like the items in the "Applications" and "Documents" tabs have. That's inconsistent.
Comment 2 Lukas Lipka 2007-12-19 23:17:41 UTC 
Created attachment 188332 [details]
Proposed solution
Comment 3 Forgotten User CRPsQFwJ3b 2007-12-21 00:21:49 UTC 
* bookmarks-agent.c

Changes there look fine to me.

* main-menu-ui.c

This code is not needed. The bookmarks-agent has a gnomevfs monitor on ~/.gtk-bookmarks and it invokes update_items, which fires a property-changed (notify::) which is handled by tile-table by reloading the table.

* directory-tile.c

It seems that by design the favorite places were meant to be handled as normal directories (thus the directory-tile.c use), but now we want to handle them as bookmarks. That's why we should rather have a bookmark-tile and have your code for handling bookmark specific behavior there. This would also require some refactoring (search-and-replace) to make user of the bookmark-tile and not a directory-tile in the rest of the code.

Thanks for your work. Looking forward to the next iteration. :)
Comment 4 Forgotten User CRPsQFwJ3b 2007-12-21 00:34:08 UTC 
Also not that the directory-tile is used for recent documents, so your patch affects also those. +1 for bookmark-tile :)
Comment 5 Lukas Lipka 2007-12-23 11:06:30 UTC 
Created attachment 188620 [details]
Proposed solution
Comment 6 Stephan Binner 2008-04-06 07:29:43 UTC 
Still same on today's Factory Live-CD.
Comment 7 Federico Mena Quintero 2008-04-22 23:12:04 UTC 
Reassigning to myself to review the patch.
Comment 8 Tehmasp Chaudhri 2008-08-27 05:20:28 UTC 
is there a quick fix for this? - is there a file that contains the user-defined 'Places'  that one could remove to get rid of the un-removable entries under 'Places'.  I don't want to get rid of the stock entries.
Comment 9 Federico Mena Quintero 2008-08-27 15:42:21 UTC 
(In reply to comment #8 from Tehmasp Chaudhri)
> is there a quick fix for this? - is there a file that contains the user-defined
> 'Places'  that one could remove to get rid of the un-removable entries under
> 'Places'.  I don't want to get rid of the stock entries.

You can edit ~/.gtk-bookmarks for this.
Comment 10 Larry Finger 2011-04-04 03:45:39 UTC 
The version with which you had the bug is now obsolete. I'll close this as NORESPONSE. If you can still reproduce it in current 11.4, please reopen the bug and move it to the appropriate version. Thanks!