Bug 328939 - sax2: NoModelines profile not working properly
Summary: sax2: NoModelines profile not working properly
Status: VERIFIED FIXED
Alias: None
Product: openSUSE 10.3
Classification: openSUSE
Component: SaX2 (show other bugs)
Version: RC 3
Hardware: Other Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Marcus Schaefer
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-27 14:18 UTC by Stefan Dirsch
Modified: 2007-09-28 16:41 UTC (History)
1 user (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
SaX.log (78.32 KB, text/plain)
2007-09-27 14:21 UTC, Stefan Dirsch
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Dirsch 2007-09-27 14:18:34 UTC
Although if you specify the NoModelines profile for fglrx driver SaX2 still generates a Modeline ... which results in a blackscreen with the fglrx
driver. The initial config file written to start sax2 on top of the fglrx
driver doesn't have a modeline and works, but the config file later (also used for testing) has one.

# cat sysp/maps/Driver.map
[...]
fglrx    : FireGL,NoModelines

# cat profile/FireGL
# /.../
# FireGL profile applied as driver profile to the fglrx
# driver to setup all available options of this driver
# -------------------------------------------------------
Screen->[X]->DefaultDepth    = 24


# cat profile/NoModelines 
# /.../
# NV profile applied as driver profile to the nv
# driver to disable modeline calculation
# -------------------------------------------------------
Desktop -> [X] ->  CalcModelines = no
Monitor -> [X] ->  CalcAlgorithm = XServerPool
!remove Monitor -> [X] -> Modeline

# cat profile/FireGL.addon
[empty file]

# sax2 -r -a
SaX: initializing please wait...
SaX: your current configuration will not be read in

SaX: no X-Server is running
SaX: will start own server if needed
SPP: prepare device [0] profile: FireGL
SPP: prepare device [0] profile: NoModelines
SPP: prepare device [0] profile: FireGL.addon
SPP: prepare device [1] profile: ibm-trackpoint
SPP: including prepared profile(s)...

SaX: startup

I'll attach /var/log/SaX.log.
Comment 1 Stefan Dirsch 2007-09-27 14:21:04 UTC
Created attachment 175203 [details]
SaX.log
Comment 2 Stefan Dirsch 2007-09-27 15:43:14 UTC
BTW, there are two entries in Driver.map for nv driver as you can see. :-( I also don't understand why nv uses the NVidia profile ...

# /.../
# Mapping table for X11 driver to profile 
# =====================================================
# Driver Name | Profile
# -----------------------------------------------------
nv       : Depth24,NVidia
nvidia   : Depth24,NVidia
radeon   : Depth24,Radeon
i810     : Depth24,NoDDC,LinearAlloc
sis      : SiS,Depth24
fglrx    : FireGL
tseng    : VideoRAM
intel    : Depth24,Intel
nv       : NoModelines
fbdev    : NoModelines
Comment 3 Marcus Schaefer 2007-09-27 20:16:55 UTC
the gui may add a modeline depending on the gui actions. If the added modeline
is valid I don't see a reason why this is a bug in sax2. If the fglrx driver
can't handle correct and valid modelines fix the driver ;)

If I remove adding the modeline by the gui action I would solve your problem
and re-open another one. So I'm sorry this is a wontfix
Comment 4 Stefan Dirsch 2007-09-27 21:09:51 UTC
I do not understand your comment, Marcus. I thought the purpose of NoModelines profile was to *not* generate any Modelines in xorg.conf at all ? Am I that wrong here? At least then the name of this profile would be rather misleading. And for a standard mode like 1280x1024 really no modeline is required. Which is generated even with "sax2 -r -a", so no GUI action is involved at all.
Comment 5 Stefan Dirsch 2007-09-28 06:42:32 UTC
Not to forget comment #2 ... 
Comment 6 Marcus Schaefer 2007-09-28 08:44:53 UTC
* in reply to comment #2: if you have nv in use and install the binary nvidia
  driver you need to detect that this has happened. The NVidia profile checks
  if the real nvidia driver is installed and if not it remains to use the nv
  driver. Anyway the driver map is wrong there are two nv entries in it. Don't
  know who added that... changed it

* in reply to comment #4: the profile does what it should do but the GUI can
  add modelines if needed. I added a check to the variables set in the
  profile file


package available on BS
Comment 7 Stefan Dirsch 2007-09-28 09:26:53 UTC
Thanks for explanation and fixing this issue, Marcus!

> Anyway the driver map is wrong there are two nv entries in it. Don't know
> who added that... changed it

-------------------------------------------------------------------
Thu Apr 26 10:11:26 CEST 2007 - ms@suse.de

- disabled modeline calculation for nv driver (#230961)

Thanks for merging the two nv driver lines in Driver.map.
Comment 8 Stefan Dirsch 2007-09-28 12:57:12 UTC
For some reasons the fix doesn't work for me. The Modeline is still generated. :-( I've tested the current SaX2 version from the buildsystem.

* Fr Sep 28 2007 ms@suse.de
- fixed modeline trigger in GUI (#328939)

I can provide a machine for you for testing. Just set to NEEDINFO. :-)
Comment 9 Marcus Schaefer 2007-09-28 15:07:00 UTC
really fixed and tested now
Comment 10 Stefan Dirsch 2007-09-28 16:41:49 UTC
Indeed. Thanks a lot!