Bug 334550 - gnome-main-menu fails to open on very first click
Summary: gnome-main-menu fails to open on very first click
Status: RESOLVED FIXED
Alias: None
Product: openSUSE 10.3
Classification: openSUSE
Component: GNOME (show other bugs)
Version: Final
Hardware: Other Other
: P5 - None : Critical (vote)
Target Milestone: ---
Assignee: Scott Reeves
QA Contact: E-mail List
URL:
Whiteboard: gnome-function-does-not-work
Keywords:
Depends on:
Blocks: main-menu-behavior
  Show dependency treegraph
 
Reported: 2007-10-17 13:05 UTC by JP Rosevear
Modified: 2008-01-10 21:33 UTC (History)
3 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
proposed fix (1.05 KB, patch)
2007-11-07 19:40 UTC, James Krehl
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description JP Rosevear 2007-10-17 13:05:47 UTC
gnome-main-menu fails to open on very first click.  I'm sure we fixed this for SP1.
Comment 1 JP Rosevear 2007-10-17 23:16:24 UTC
I'm struggling to reproduce this reliably.  I've seen it at least twice today, but can't get it to happen at will.  
Comment 2 James Krehl 2007-10-30 22:44:10 UTC
Alright, I think I might've fixed this one.  Please try the packages here ...

http://w3.suse.de/~jimmyk/gnome-main-menu/openSUSE-10.3/v0.9.8-94.3b/

and see if you can replicate still.

Thanks!
jim
Comment 3 Magnus Boman 2007-10-30 23:13:27 UTC
Jim,
If you keep clicking on Computer (with a delay less than a second in between), it will eventually either stop closing Slab, or stop opening Slab... I *think* that ties into this bug (Happens even after updating with your new packages).
Comment 4 James Krehl 2007-10-31 16:35:07 UTC
(In reply to comment #3 from Magnus Boman)
> Jim,
> If you keep clicking on Computer (with a delay less than a second in between),
> it will eventually either stop closing Slab, or stop opening Slab... I *think*
> that ties into this bug (Happens even after updating with your new packages).
> 

That's because multi-clicks are debounced.  It's always worked this way.  If this is bad behavior, please file a separate bug.

Thanks!
jim
Comment 5 JP Rosevear 2007-10-31 20:37:42 UTC
Ok, I've installed it, but as noted I'm note able to replicate it every time so I'll run it for a few days.  If you have steps Jim or an idea how to trigger it, let me know.
Comment 6 JP Rosevear 2007-11-06 16:48:58 UTC
Ok, I managed to replicate it on FACTORY every time, the new packages solve the problem.

Please attach the patch for review.
Comment 7 James Krehl 2007-11-07 19:40:31 UTC
Created attachment 182490 [details]
proposed fix

Here's a proposed patch for Federico to review.
Comment 8 Federico Mena Quintero 2007-11-07 23:27:55 UTC
(In reply to comment #7 from James Krehl)
> 
> Here's a proposed patch for Federico to review.

This makes the first click work, and it debounces the menu.  For that, it's good to go.

Some comments for the future:

* The slab window is a GTK_WINDOW_POPUP as per the Glade file, so the window will be OverrideRedirect (i.e. not managed by the window manager).  Thus, gtk_window_present_with_time() doesn't really have any special effect on it.  You could simply use gtk_widget_show() for it.

* I still think this needs to be done at the level of "button_press_event", not at the level of the "clicked" signal.  For example, right now you can do this:

  1. Click on the main-menu to open it.

  2. Start clicking multiple times rapidly on the Computer button.

The menu will hide, but then the Computer button will go up and down repeatedly with seemingly no action.  A better implementation of debouncing would hide the main-menu, but prevent the actual visible press-and-release from happening.
Comment 9 James Krehl 2007-11-08 19:05:14 UTC
Could I get a SWAMP ID for this fix?

Thanks,
Jim Krehl
Comment 16 Federico Mena Quintero 2007-12-18 15:54:59 UTC
There's a test package here with the aforementioned patch:
http://download.opensuse.org/repositories/home:/federico-mena:/10.3/openSUSE_10.3

It fixes the problem for me.

I'll put this patch in our main package as soon as the Main Menu bug week is over:
http://en.opensuse.org/GNOME/Main_menu_bug_week
Comment 17 Scott Reeves 2008-01-09 23:08:45 UTC
submitted to 10.3 for inclusion in the upcoming general update - test packages are in the 10.3 update test repo - http://download.opensuse.org/repositories/GNOME:/test-updates:/10.3/openSUSE_10.3/
Comment 18 James Ogley 2008-01-10 21:33:42 UTC
Tested packages from this repo and confirm that this is fixed.