Bug 372983 - oo.org icon looks horrible
Summary: oo.org icon looks horrible
Status: RESOLVED FIXED
Alias: None
Product: openSUSE 11.1
Classification: openSUSE
Component: OpenOffice.org (show other bugs)
Version: Factory
Hardware: Other Other
: P4 - Low : Normal (vote)
Target Milestone: ---
Assignee: Jan Holesovsky
QA Contact: Ke Yu
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-21 16:46 UTC by Felix Möller
Modified: 2008-10-20 18:17 UTC (History)
1 user (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
screenshot (11.58 KB, image/png)
2008-03-21 16:48 UTC, Felix Möller
Details
screenshot (93.00 KB, image/png)
2008-08-11 20:10 UTC, Felix Möller
Details
screenshot of patched openoffice in kde3 (91.80 KB, image/png)
2008-10-20 17:35 UTC, Felix Möller
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Möller 2008-03-21 16:46:22 UTC
The KDE4 default taskbar is a little bigger than the KDE4 one. Now the OpenOffice.org icon looks horrible. Have a look at the attached screenshot.
Comment 1 Felix Möller 2008-03-21 16:48:12 UTC
Created attachment 203425 [details]
screenshot

This must be the wrong icon the resolution is way to low.
Comment 2 Eric Ward 2008-03-24 16:05:03 UTC
Reassigning to Petr.
Comment 3 Petr Mladek 2008-05-14 15:28:08 UTC
Hmm, it uses the ugly icon from the original OOo icon theme. Kendy, would be possible to show the Jakub's /usr/share/icons/hicolor/32x32/apps/ooo-gulls.png or the other best appropriate size?
Comment 4 Petr Mladek 2008-05-14 15:29:46 UTC
See also the bug #361781. It might be partly related.
Comment 5 Felix Möller 2008-05-29 14:26:47 UTC
Ok I found something interesting. The icon of the Extras -> Options window looks ok.
Comment 6 Felix Möller 2008-08-11 20:10:58 UTC
Created attachment 232803 [details]
screenshot

the problem changed a little. as icons seem to not scale any longer...
Comment 7 Felix Möller 2008-08-11 20:12:27 UTC
oops that was the wrong checkbox ... 
Comment 8 Felix Möller 2008-08-11 23:47:59 UTC
reply to comment #3 from Petr Mladek)
> Hmm, it uses the ugly icon from the original OOo icon theme. Kendy, would be
> possible to show the Jakub's /usr/share/icons/hicolor/32x32/apps/ooo-gulls.png
> or the other best appropriate size?
it is not the icon's fault it is just the wrong one used, see comment #5

==============================================================

So, where is the oo icon coming from?

I canot find it on my harddrive, there are just the following.
/usr/share/icons/hicolor/16x16/apps/ooo-writer.png
/usr/share/icons/hicolor/22x22/apps/ooo-writer.png
/usr/share/icons/hicolor/24x24/apps/ooo-writer.png
/usr/share/icons/hicolor/32x32/apps/ooo-writer.png
/usr/share/icons/hicolor/48x48/apps/ooo-writer.png
/usr/share/icons/hicolor/scalable/apps/ooo-writer.svg
/usr/share/pixmaps/ooo-writer.png

I downloaded the oo source from sun and it seems to me the relevant icons are at BEB300_m3/default_images/res/odt* and there is a 48px version of the icon. (In 

But that file is not in my installation...
Comment 9 Felix Möller 2008-08-12 00:22:53 UTC
Ok I guess I found it in vcl/unx/source/window/salframe.cxx line 997:

            const String& rWM( pDisplay_->getWMAdaptor()->getWindowManagerName() );
            if( rWM.EqualsAscii( "KWin" ) )                     // assume KDE is running
                iconSize = 16;
            static bool bGnomeIconSize = false;
            static bool bGnomeChecked = false;

Petr do you know why the KDE size is hardcoded to 16?
Comment 10 Petr Mladek 2008-08-12 09:08:46 UTC
Kendy, you are the expert on the KDE stuff in OOo. What do you think about the hardcoded size 16? See above the comment #9.
Comment 11 Felix Möller 2008-09-04 20:24:17 UTC
So is there anything to test? I think today KDE is capable of icons bigger than 16px.
Comment 12 Christoph Thiel 2008-09-25 11:06:41 UTC
*ping* -- what's the news on this bug?
Comment 13 Felix Möller 2008-09-27 13:59:33 UTC
I was thinking about trying to build a patched oo in the osbs myself, but oo currently does not have an icon at all for me.

It has just the standard Xorg X. :-(

OpenOffice_org-filters-3.0.0.4-3.3        
OpenOffice_org-templates-de-3.0-1.5       
OpenOffice_org-libs-core-3.0.0.4-1.3      
OpenOffice_org-l10n-extras-3.0.0.4-1.3
OpenOffice_org-impress-3.0.0.4-1.3
OpenOffice_org-mailmerge-3.0.0.4-1.3
OpenOffice_org-templates-labels-letter-1.0-4.33
OpenOffice_org-ure-3.0.0.4-1.3
OpenOffice_org-help-en-US-3.0.0.4-1.3
OpenOffice_org-base-3.0.0.4-1.3
OpenOffice_org-templates-labels-a4-1.0-4.33
OpenOffice_org-branding-openSUSE-3.0-10.9
OpenOffice_org-l10n-de-3.0.0.4-1.3
OpenOffice_org-libs-gui-3.0.0.4-1.3
OpenOffice_org-writer-3.0.0.4-1.3
OpenOffice_org-thesaurus-en-20060111-2.36
OpenOffice_org-3.0.0.4-1.3
OpenOffice_org-libs-extern-3.0.0.4-3.3
OpenOffice_org-help-de-3.0.0.4-1.3
OpenOffice_org-calc-3.0.0.4-1.3
OpenOffice_org-math-3.0.0.4-1.3
OpenOffice_org-filters-optional-3.0.0.4-3.3
OpenOffice_org-Quickstarter-1.0-681.31
OpenOffice_org-icon-themes-3.0.0.4-1.3
OpenOffice_org-thesaurus-de-20080406-2.36
OpenOffice_org-templates-presentation-layouts-3.0-1.5
OpenOffice_org-components-3.0.0.4-1.3
OpenOffice_org-hyphen-20080414-1.36
OpenOffice_org-templates-en-3.0-1.5
OpenOffice_org-pyuno-3.0.0.4-1.3
OpenOffice_org-draw-3.0.0.4-1.3

Petr, how do I get an icon back?
Comment 14 Petr Mladek 2008-09-29 08:50:11 UTC
You evidently used the totaly reworked split OOo from FACTORY. It has many issues including the missing icons. I do not know why they are missing. I still need to fix it...

As a temporary solution, I would suggest to debug this problem with the non-split sources from the OpenOffice.org:UNSTABLE project. I am sorry for the inconvenience.
Comment 15 Felix Möller 2008-10-18 20:55:42 UTC
The packages seem to be fixed now:

$ rpm -qa 'OpenOffice_org*'
OpenOffice_org-components-3.0.0.6-1.3
OpenOffice_org-help-en-US-3.0.0.6-1.3
OpenOffice_org-pyuno-3.0.0.6-1.3
OpenOffice_org-draw-3.0.0.6-1.3
OpenOffice_org-templates-labels-letter-1.0-4.41
OpenOffice_org-libs-core-3.0.0.6-1.3
OpenOffice_org-Quickstarter-1.0-681.43
OpenOffice_org-thesaurus-en-20060111-4.5
OpenOffice_org-libs-extern-3.0.0.6-1.3
OpenOffice_org-l10n-de-3.0.0.6-1.3
OpenOffice_org-3.0.0.6-1.2
OpenOffice_org-l10n-extras-3.0.0.6-1.3
OpenOffice_org-templates-de-3.0-1.17
OpenOffice_org-libs-gui-3.0.0.6-1.3
OpenOffice_org-icon-themes-3.0.0.6-1.2
OpenOffice_org-help-de-3.0.0.6-1.3
OpenOffice_org-mailmerge-3.0.0.6-1.3
OpenOffice_org-calc-3.0.0.6-1.3
OpenOffice_org-templates-labels-a4-1.0-4.41
OpenOffice_org-math-3.0.0.6-1.3
OpenOffice_org-filters-optional-3.0.0.6-1.3
OpenOffice_org-templates-en-3.0-1.17
OpenOffice_org-templates-presentation-layouts-3.0-1.17
OpenOffice_org-branding-openSUSE-3.0-24.2
OpenOffice_org-hyphen-20080929-36.5
OpenOffice_org-base-3.0.0.6-1.3
OpenOffice_org-thesaurus-de-20080406-4.5
OpenOffice_org-icon-themes-prebuilt-3.0.0.6-1.2
OpenOffice_org-ure-3.0.0.6-1.3
OpenOffice_org-impress-3.0.0.6-1.3
OpenOffice_org-filters-3.0.0.6-1.3
OpenOffice_org-writer-3.0.0.6-1.3

But the icon is still low rew :-(

So which source rpm does use vcl/unx/source/window/salframe.cxx ? 
OpenOffice_org-libs-gui seems a good candidate. Let's see...
Comment 16 Felix Möller 2008-10-18 21:52:52 UTC
As the src.rpm file contains the whole cvs history I had a look at it:

macbook:/usr/src/packages/SOURCES/ooo300-m9-libs_gui/vcl/unx/source/window # cvs annotate salframe.cxx | grep -A 5 -B 5 KDE
cvs annotate: warning: failed to open /root/.cvspass for reading: No such file or directory

Annotations for salframe.cxx
***************
1.108        (pl       03-Dec-01):             XFree( pIconSize );
1.78         (pl       06-Sep-01):         }
1.78         (pl       06-Sep-01):         else
1.78         (pl       06-Sep-01):         {
1.165        (kz       18-Nov-03):             const String& rWM( pDisplay_->getWMAdaptor()->getWindowManagerName() );
1.88         (obr      18-Oct-01):             if( rWM.EqualsAscii( "KWin" ) )                  // assume KDE is running
1.78         (pl       06-Sep-01):                 iconSize = 16;
1.88         (obr      18-Oct-01):             static bool bGnomeIconSize = false;
1.88         (obr      18-Oct-01):             static bool bGnomeChecked = false;
1.88         (obr      18-Oct-01):             if( ! bGnomeChecked )
1.88         (obr      18-Oct-01):             {

So the icon code was added seven years ago ...

Right now I am building the OpenOffice_org-libs-gui in home:felixmoeller2 ...
Comment 17 Felix Möller 2008-10-18 22:33:54 UTC
Ok I have a fixed package at ftp://ftp5.gwdg.de/pub/opensuse/repositories/home%3A/felixmoeller2/openSUSE_Factory/i586/OpenOffice_org-libs-gui-3.0.0.6-8.1.i586.rpm

And now the ooo icon looks ok.

I just did:
--- vcl/unx/source/window/salframe.cxx.orig     2008-10-18 23:09:38.000000000 +0200
+++ vcl/unx/source/window/salframe.cxx  2008-10-18 23:10:04.000000000 +0200
@@ -996,7 +996,7 @@
         {
             const String& rWM( pDisplay_->getWMAdaptor()->getWindowManagerName() );
             if( rWM.EqualsAscii( "KWin" ) )                    // assume KDE is running
-                iconSize = 16;
+                iconSize = 48;
             static bool bGnomeIconSize = false;
             static bool bGnomeChecked = false;
             if( ! bGnomeChecked )

it is probably best to remove the whole if statement then we'd have 32px I guess.

Petr are you going to apply it or do we have to wait even longer for this single line?
Comment 18 Jan Holesovsky 2008-10-20 16:17:45 UTC
Felix, thanks for the patch!  Please - does it work correctly when it's run in KDE3?  If yes, I'll commit it to ooo-build immediately; if not, the detection of the desktop environment has to be improved to distinguish between KDE3 and KDE4; should be easy - for the reference, the code is in vcl/unx/source/plugadapt/salplug.cxx .
Comment 19 Felix Möller 2008-10-20 17:35:40 UTC
Created attachment 246632 [details]
screenshot of patched openoffice in kde3

Here is a screenshot of my patched openoffice running a fresh kde3 factory install.

# rpm -q kdebase3
kdebase3-3.5.10-15.15
Comment 20 Jan Holesovsky 2008-10-20 18:17:05 UTC
Ah - so apparently it improves the experience even in KDE3 - thank you again for the patch, and sorry that it took so long :-(  Applied in ooo-build trunk:

2008-10-20  Jan Holesovsky  <kendy@suse.cz>

	* patches/dev300/vcl-bigger-icons-kde-gnome.diff: Bigger application
	  icons in KDE and Gnome.
Comment 21 Jan Holesovsky 2008-10-20 18:17:51 UTC
[For the reference, the up-stream issue is here: http://www.openoffice.org/issues/show_bug.cgi?id=95220]