Bug 385553 - metacity fullscreen not using the whole screen area
Summary: metacity fullscreen not using the whole screen area
Status: RESOLVED FIXED
: 396044 (view as bug list)
Alias: None
Product: openSUSE 11.0
Classification: openSUSE
Component: GNOME (show other bugs)
Version: Factory
Hardware: Other openSUSE 10.3
: P2 - High : Major (vote)
Target Milestone: ---
Assignee: Federico Mena Quintero
QA Contact: E-mail List
URL:
Whiteboard: gnome-function-does-not-work, gnome-w...
Keywords:
Depends on:
Blocks: 391932 randr-tracker
  Show dependency treegraph
 
Reported: 2008-05-01 11:59 UTC by Vincent Untz
Modified: 2020-05-19 09:21 UTC (History)
4 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---
coolo: SHIP_STOPPER-


Attachments
output from (xprop -root | grep WORKAREA) (1.45 KB, application/octet-stream)
2008-05-15 22:42 UTC, Ted Bullock
Details
output from xdpyinfo (6.21 KB, application/octet-stream)
2008-05-15 22:43 UTC, Ted Bullock
Details
output from xrandr (690 bytes, application/octet-stream)
2008-05-15 22:45 UTC, Ted Bullock
Details
Screenshot showing firefox maximized to only part of the screen (271.37 KB, image/png)
2008-05-15 22:45 UTC, Ted Bullock
Details
output from xrandr (584 bytes, application/octet-stream)
2008-05-18 20:11 UTC, John Anderson
Details
output from (xprop -root | grep WORKAREA) (1.45 KB, application/octet-stream)
2008-05-18 20:12 UTC, John Anderson
Details
output from xdpyinfo (6.21 KB, application/octet-stream)
2008-05-18 20:13 UTC, John Anderson
Details
metacity log (1.45 MB, text/plain)
2008-05-21 05:40 UTC, Casual J. Programmer
Details
metacity log (from dell 700m/855gm) (72.25 KB, application/octet-stream)
2008-05-23 19:07 UTC, Ted Bullock
Details
metacity-bnc385553-buggy-intel-xinerama.diff (3.42 KB, patch)
2008-05-26 21:10 UTC, Federico Mena Quintero
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Untz 2008-05-01 11:59:30 UTC
This is the metacity specific part of bug 343858.

Federico had a patch: https://bugzilla.novell.com/attachment.cgi?id=190636 but it seems to be causing problems.
Comment 1 Ted Bullock 2008-05-14 22:23:59 UTC
Can we make this bug a blocker?

This is deeply annoying.
Comment 2 Federico Mena Quintero 2008-05-15 19:16:31 UTC
Ted, do you have a machine with the problematic Intel chipset?  Would you be willing to test some packages with patches? :)

Regardless of that, can you please provide the output of

  xprop -root | grep WORKAREA

when you experience the problem with metacity?

Also, can you please provide the output of "xdpyinfo" and "xrandr"?
Comment 3 Ted Bullock 2008-05-15 20:38:45 UTC
My laptop is a Dell 700m.

Chipset is 855GM

When in GNOME(metacity) I hit the problem whenever I attempt to maximize a window when it is in the top left 1024x768 pixels of the screen.

As soon, as the window moves outside of that area in any way I am able to fully maximize.

Native resolution is 1280x800.

Note that this also affects video playback as well.  When totem is in the top left 1024x768, it will not draw the video, as soon as it moves out of that area, it draws the video.

Requested output will follow shortly.  Along with Screenshot demonstrating the problem.

-Ted
Comment 4 Ted Bullock 2008-05-15 22:42:41 UTC
Created attachment 215775 [details]
output from (xprop -root | grep WORKAREA)
Comment 5 Ted Bullock 2008-05-15 22:43:24 UTC
Created attachment 215776 [details]
output from xdpyinfo
Comment 6 Ted Bullock 2008-05-15 22:45:11 UTC
Created attachment 215777 [details]
output from xrandr
Comment 7 Ted Bullock 2008-05-15 22:45:52 UTC
Created attachment 215779 [details]
Screenshot showing firefox maximized to only part of the screen
Comment 8 Federico Mena Quintero 2008-05-16 01:26:41 UTC
Thanks, Ted.  I'll revise the patch and make some packages for you to test.
Comment 9 John Anderson 2008-05-18 20:10:06 UTC
I also have this issue with a Dell E1505.

00:02.0 VGA compatible controller: Intel Corporation Mobile 945GM/GMS, 943/940GML Express Integrated Graphics Controller (rev 03)
00:02.1 Display controller: Intel Corporation Mobile 945GM/GMS/GME, 943/940GML Express Integrated Graphics Controller (rev 03)


I usually just xrandr --output VGA --off    to fix it, but this is obviously a problem for when I want to use a projector
Comment 10 John Anderson 2008-05-18 20:11:08 UTC
Created attachment 216250 [details]
output from xrandr
Comment 11 John Anderson 2008-05-18 20:12:10 UTC
Created attachment 216251 [details]
output from (xprop -root | grep WORKAREA)
Comment 12 John Anderson 2008-05-18 20:13:02 UTC
Created attachment 216252 [details]
output from xdpyinfo
Comment 13 Federico Mena Quintero 2008-05-19 15:48:48 UTC
Please download the packages here:
http://www.gnome.org/~federico/misc/metacity/

Then, please do this:

1. Install the packages

2. Run this from a terminal:

    METACITY_DEBUG=1 METACITY_VERBOSE=1 METACITY_USE_LOGFILE=1 metacity --replace

3. Try to maximize a window or reproduce the bug.

Please tell us if this works.  If it doesn't, attach /tmp/metacity-XXXXX-debug-log-XXXXX to this bug; it contains some logging information that will be useful to see what's going on :)
Comment 14 Ted Bullock 2008-05-20 16:14:50 UTC
Will test this this afternoon.

I've been hitting a new bug though where the mouse freezes up as soon as I enter gnome.

I will be re-installing later today and will post the update.
Comment 15 JP Rosevear 2008-05-20 17:57:43 UTC
(In reply to comment #14 from Ted Bullock)
> Will test this this afternoon.
> 
> I've been hitting a new bug though where the mouse freezes up as soon as I
> enter gnome.

This is bug 388236, there are test packages in the bug (or possibly synced to factory now).

Comment 16 Casual J. Programmer 2008-05-21 05:33:07 UTC
After applying measures from comment #13 it seems to work here. 

Not only do windows maximize properly, but also does the tray applet show correct resolution (1280x800) on mouseover as well offer a choice of screen resolution, screen rotation and refresh rate in the context menu.

The created log still contains errors.

Comment 17 Casual J. Programmer 2008-05-21 05:40:48 UTC
Created attachment 217096 [details]
metacity log
Comment 18 Danny Al-Gaaf 2008-05-21 12:55:15 UTC
(In reply to comment #9 from John Anderson)
> I usually just xrandr --output VGA --off    to fix it, but this is obviously a
> problem for when I want to use a projector

For me xrandr --auto works also as workaround

Comment 19 Casual J. Programmer 2008-05-21 16:31:00 UTC
There is one problem left though.

For me this _only_ works for the user that was active when I implemented the change. Other users get to see just background, no panel no icons.

When I, again change DISPLAYMANAGER_RANDR_MODE_auto to

1280x800_60 68.90 1280 1301 1333 1408 800 804 808 816 -hsync -vsync

from the default 

1024x768_60 64.11 1024 1080 1184 1344 768 769 772 795 -HSync +Vsync

it is working for other users as well, only the tray applets context menu then offers "Screen Rotation" as only option.

Comment 20 Federico Mena Quintero 2008-05-21 17:22:18 UTC
Thanks for the log file, CJP :)  This indicates that everything is working fine.  The rest of your problems are not related to Metacity.

I submitted the attached patch to autobuild for openSUSE 11; it should hit Beta4, I think.

* Wed May 21 2008 - federico@novell.com
- Added metacity-bnc385553-buggy-intel-xinerama.diff to fix
  https://bugzilla.novell.com/show_bug.cgi?id=385553 - If there are
  just two overlapping monitors, make Metacity think that there is a
  single big monitor.  This should fix maximized windows on laptops
  with buggy X drivers for Intel graphics chipsets.
Comment 21 Ted Bullock 2008-05-23 17:47:59 UTC
So the version in factory right now does report that the resolution is correct for my laptop (1280x800).

However, windows are still not maximizing to the fill the entire screen.

That said, the panel is covering the entire bottom of the screen.

Thoughts?

-Ted
Comment 22 Federico Mena Quintero 2008-05-23 18:27:54 UTC
Ted, could you please run

  rpm -q --changelog metacity | head

You should see something like

* Fri May 16 2008 federico@novell.com
- Added metacity-bnc385553-buggy-intel-xinerama.diff to fix
  https://bugzilla.novell.com/show_bug.cgi?id=385553 - If there are
  just two overlapping monitors, make Metacity think that there is a
  single big monitor.  This should fix maximized windows on laptops
  with buggy X drivers for Intel graphics chipsets.

If you get something else, then you need a newer package.

If you *do* get something similar, could you please run

METACITY_DEBUG=1 METACITY_VERBOSE=1 METACITY_USE_LOGFILE=1 metacity
--replace

again and attach /tmp/metacity-xxxx-debug-log-xxxx to this bug?  Make sure you send the latest file, as you may have several of them in /tmp now :)
Comment 23 Ted Bullock 2008-05-23 19:07:29 UTC
Created attachment 217890 [details]
metacity log (from dell 700m/855gm)

Ok, so it turns out that the package in factory now was last update updated May 13, so it didn't include your change.

That said,

I installed the updates you posted above.

Result was not good, metacity died.

See new attachment for log
Comment 24 Casual J. Programmer 2008-05-25 06:31:05 UTC
@ Federico: In Comment #20 you state: 

"The rest of your problems ( from Comment # 19 ) are not related to Metacity" 

which isn't exactly helpful.

Would you mind pointing me to the right direction ( Either open Bug on that, against what ?? Or else follow an existing one. )

Thanks

Comment 25 Casual J. Programmer 2008-05-26 07:10:58 UTC
Whatever is intended here, it is now a real blocker. Updating a system previously clean installed from factory & updated just now renders UI completely inaccessible for both users ( root & casualprogrammer ) only the background is visible, no panel, no icons.

For the system used to verify this fix in comment #19 the only functional user now has background and panel, but no icons and backround has no context menu.
Comment 26 JP Rosevear 2008-05-26 12:47:02 UTC
I reverted the patch for now.
Comment 27 Stephan Kulow 2008-05-26 14:37:50 UTC
ok, back to major then
Comment 28 Casual J. Programmer 2008-05-26 17:20:59 UTC
As suggested by Vuntz, I checked the broken installation if metacity is running at all. As I reported to him on IRC:

casualprogrammer: vuntz: background=yes, panel=no, icons=no, context-menu=no, metacity_running=yes
Comment 29 Federico Mena Quintero 2008-05-26 21:10:31 UTC
Created attachment 218200 [details]
metacity-bnc385553-buggy-intel-xinerama.diff

Argh!  My patch had a stupid bug which could cause crashes (array bounds overflow).  This is the new patch I'm building...
Comment 30 John Anderson 2008-05-26 22:16:04 UTC
Latest patch works great for me!
Comment 31 Federico Mena Quintero 2008-05-27 01:10:17 UTC
Confirmed on IRC that the new patch works :)  I've submitted this to autobuild for openSUSE 11.0.

* Mon May 26 2008 - federico@novell.com
- Updated metacity-bnc385553-buggy-intel-xinerama.diff for
  https://bugzilla.novell.com/show_bug.cgi?id=385553 - Deal with buggy
  Intel graphics drivers.  Fix an array bounds overrun in the last
  version of the patch.

Casualprogrammer, can you please install from here while the packages get built for updates:

http://www.gnome.org/~federico/misc/metacity/

If you find any further problems, please file new bugs for them --- I'm 99% convinced that Metacity is fixed for this general Intel 915 issue :)
Comment 32 Casual J. Programmer 2008-05-27 06:25:58 UTC
works here too :-)
also works for newly added users.

only the tray icon says we are at 1024x786 and doesn't offer a choice of resolutions, while choosing "Screen Resolution" from the control center shows 1280x800

Comment 33 Federico Mena Quintero 2008-05-27 15:52:06 UTC
Yeah, the tray icon is likely to be broken; that may be bug #385171.  I'll talk to you on IRC about this.
Comment 34 Casual J. Programmer 2008-05-30 06:05:14 UTC
The bug has made it to RC1 somehow :-(

Installing rpm from comment #31 still fixes it, although packages are named identical, what gives ??
Comment 36 Federico Mena Quintero 2008-06-02 15:26:07 UTC
OK, I just checked - indeed the patch didn't make it for RC1.  It will be in openSUSE 11.0 final (it's in now).

Sorry about the identically-named patches; I expected the build system to bump the revision number automatically, but it seems that that doesn't happen if you build things by hand...
Comment 37 JP Rosevear 2008-06-02 16:36:57 UTC
*** Bug 396044 has been marked as a duplicate of this bug. ***
Comment 38 OBSbugzilla Bot 2020-05-19 09:21:33 UTC
This is an autogenerated message for OBS integration:
This bug (385553) was mentioned in
https://build.opensuse.org/request/show/807148 Backports:SLE-12-SP4 / atril+caja+caja-dropbox+caja-extensions+caja-terminal+engrampa+eom+filemanager-actions+galculator+gtk2-engine-murrine+gucharmap+libfakekey+libmatekbd+libmatemixer+libmateweather+marco+mate-applet-softupd+mate-applets+mate-backgrounds+mate-branding-openSUSE+mate-calc+mate-common+mate-control-center+mate-desktop+mate-eiciel+mate-icon-theme+mate-icon-theme-faenza+mate-indicator-applet+mate-media+mate-menu+mate-menus+mate-netbook+mate-notification-daemon+mate-panel+mate-polkit+mate-power-manager+mate-screensaver+mate-sensors-applet+mate-session-manager+mate-settings-daemon+mate-system-monitor+mate-terminal+mate-themes+mate-user-guide+mate-user-share+mate-utils+mathjax+metacity+mozo+pluma+python-Unidecode