Bug 402315 - SLAB menu opens to the left on small screens when it should open to the right
Summary: SLAB menu opens to the left on small screens when it should open to the right
Status: RESOLVED FIXED
: 447822 (view as bug list)
Alias: None
Product: openSUSE 11.0
Classification: openSUSE
Component: GNOME (show other bugs)
Version: Final
Hardware: i686 openSUSE 11.0
: P2 - High : Major (vote)
Target Milestone: ---
Assignee: Federico Mena Quintero
QA Contact: E-mail List
URL:
Whiteboard: gnome-showstopper, gnome-wrong-out-of...
Keywords:
Depends on:
Blocks: main-menu-behavior
  Show dependency treegraph
 
Reported: 2008-06-20 18:33 UTC by Brian Singer
Modified: 2010-11-27 16:41 UTC (History)
4 users (show)

See Also:
Found By: Product Management
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
menu should open to the right (103.67 KB, image/png)
2008-06-20 18:33 UTC, Brian Singer
Details
gnome-main-menu-bnc402315-slab-on-small-monitors.diff (1.00 KB, patch)
2009-02-28 02:17 UTC, Federico Mena Quintero
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Singer 2008-06-20 18:33:35 UTC
Created attachment 223475 [details]
menu should open to the right

On a fresh intall of openSUSE 11.0 on a subnotebook, the slab menu tries to open to the left which makes it useless. It should open to the right. The screenshot should make things clear.
Comment 1 Federico Mena Quintero 2008-06-23 17:28:33 UTC
This happens in slab_window_allocate_cb().  The logic to move the window if it doesn't fit in the default location is wrong.

Setting priority to high as applications can't be launched at all while the bug is present.
Comment 2 Magnus Boman 2008-06-24 01:26:52 UTC
Federico, when you digg in to this, can you make sure that we get the correct behavior with the patch attached to http://bugzilla.gnome.org/show_bug.cgi?id=398552 as well? The first time g-m-m is opened after applying that patch, it will open partly off screen.
Comment 3 Federico Mena Quintero 2009-02-28 02:17:26 UTC
Created attachment 276170 [details]
gnome-main-menu-bnc402315-slab-on-small-monitors.diff

Magnus, could you try this patch plus that other one you mention for line wrapping?
Comment 4 Magnus Boman 2009-02-28 23:29:53 UTC
So, your patch doesn't do anything for my issue. It seems as the code needs to extended to catch size-allocate signals. I opened a new bug report for that though (bnc#480765)
Comment 5 David Liang 2009-08-11 03:36:08 UTC
*** Bug 447822 has been marked as a duplicate of this bug. ***
Comment 6 Federico Mena Quintero 2010-02-25 19:46:27 UTC
I've confirmed that this patch works for small displays, and it's pushed upstream now.

I'll check the interaction with the patch which Magnus mentions in comment #4.
Comment 7 Federico Mena Quintero 2010-02-25 20:56:46 UTC
Works nicely for me, even with the patch for libslab from bgo#398552.  I'm not seeing the problem that Magnus mentions in bug #480765... Magnus, could you please test this again?  (I'm in openSUSE 11.2, BTW).
Comment 8 Vincent Untz 2010-11-27 16:41:49 UTC
Closing, as per last comment.