Bug 474647 - OpenFileDialog: PopupButtonPanel and PopupButton have wrong role name
Summary: OpenFileDialog: PopupButtonPanel and PopupButton have wrong role name
Status: CONFIRMED
Alias: None
Product: UI Automation
Classification: Mono
Component: Winforms - ATK (show other bugs)
Version: Release 0.9
Hardware: x86 openSUSE 11.0
: P3 - Medium : Major
Target Milestone: Release 1.1
Assignee: E-mail List
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on: 475082
Blocks:
  Show dependency tree / graph
 
Reported: 2009-02-11 07:37 UTC by calen chen
Modified: 2009-10-28 20:09 UTC (History)
0 users

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description calen chen 2009-02-11 07:37:37 UTC 
PROBLEM STATEMENT:

PopupButtonPanel has been bridged to "tool bar",
PopupButton has been bridged to "menu item" under panel role


REPRO:

1. run accerciser
2. run uia2atk/test/samples/openfiledialog.py, click "OpenDialog" button to
invoke OpenFileDialog, PopupButtonPanel with "Recently used", "Desktop", "Personal" PopupButtons in this example
3. in accercuser, expand dialog to see PopupButtonPanel and PopupButton's role name

RESULTS:

PopupButtonPanel has bridged to "tool bar",

PopupButton has been bridged to "menu item" under panel role

EXPECTED RESULTS:

I think it would be better if role name of PopupButtonPanel is "panel", and PopupButtons are "push button" as children under PopupButtonPanel

COMMENTS:
Comment 1 Sanford Armstrong 2009-02-11 16:43:56 UTC 
This is based on how it appears on Vista.  I think your suggestion would be fine, but I don't see any problem with ToolBar and MenuItem.

I am closing, but if this is causing behavior problems for you, please feel free to re-open.  As far as I can tell, appearling as ToolBar/MenuItem is not hurting anything.
Comment 2 calen chen 2009-02-12 02:31:34 UTC 
Hi Sandy, I opened this bug just because MenuItem can't rise "focused" state information for Orca to speak out when doing KeyUp/Down action, even though MenuItem has "focusable" state.  I am not sure why it appears ToolBar/MenuItem on Vista and HasKeyboardFocus always shows "False" when focus on one MenuItem. Do you have any idea? thanks!
Comment 3 calen chen 2009-04-01 02:35:09 UTC 
I think Comment#2 is relate to BUG475082, the goal is let orca can read the PopUpButtons, so please close this bug as soon as you fix bug475082, thanks :)
Comment 4 Andres Aragoneses 2009-04-30 19:40:19 UTC 
The real bug here is that those buttons should be a ToggleButton, not a MenuItem.

Working on it...
Comment 5 Sanford Armstrong 2009-05-01 00:26:30 UTC 
(In reply to comment #4)
> The real bug here is that those buttons should be a ToggleButton, not a
> MenuItem.
> 
> Working on it...

As stated before, we do it as a MenuItem because that's how it appears in Vista.  I think Calen's problem would be fixed if bug #475082 were fixed.  I don't know if it's worth the effort to reimplement them as ToggleButtons, though that may be more correct, since in Vista they don't really have a button-like appearance.  Your call.  :-)