Bug 485268 - Unit tests should fail when finding a Log.Error event
Summary: Unit tests should fail when finding a Log.Error event
Status: REOPENED
Alias: None
Product: UI Automation
Classification: Mono
Component: Winforms - General (show other bugs)
Version: Unspecified
Hardware: All All
: P2 - High : Major
Target Milestone: Release 1.1
Assignee: E-mail List
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-13 17:25 UTC by Andres Aragoneses
Modified: 2010-04-14 10:26 UTC (History)
2 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Proposed patch (2.55 KB, patch)
2009-07-11 04:42 UTC, Andres Aragoneses 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Aragoneses 2009-03-13 17:25:04 UTC 
(summary says it all)
Comment 1 Sanford Armstrong 2009-03-13 18:20:48 UTC 
Good idea.  Could do this by have an event on the Log object when errors are logged...could hook into that in fixture setup.  Is that too convoluted?
Comment 2 Andres Aragoneses 2009-07-11 04:42:06 UTC 
Created attachment 304536 [details]
Proposed patch

It's weird, the post-review script is not working for me now, so I'm attaching the patch here for now.
Comment 3 Brad Taylor 2009-07-14 16:08:25 UTC 
Move all P1 and P2 bugs into Release 1.1 milestone.
Comment 4 Andres Aragoneses 2009-07-15 15:59:55 UTC 
Fixed in r137970.
Comment 5 Michael Gorse 2010-03-30 14:10:52 UTC 
I reverted this behavior in a commit yesterday.  I think that we'd decided on removing it, and I had it removed locally anyhow because the tests were aborting because of an error that UiaDbusBridge was generating (which had nothing to do with UiaAtkBridge).
Comment 6 Forgotten User oDRaEXi7Ku 2010-04-04 13:10:42 UTC 
(In reply to comment #5)
> I reverted this behavior in a commit yesterday.

The commit was r154393.
Comment 8 Forgotten User oDRaEXi7Ku 2010-04-14 10:26:39 UTC 
Mike: I have an idea. Why don't you enable this again but, instead of having an Assert.Fail() call in the reception of the error, you could raise some exception (InvalidOperationException), so you can catch it in the exact failure you were getting, but nowhere else. This way we can mark this bug as FIXED again and you don't get the UiaDbusBridge failure. Let me know what you think.