Bugzilla – Bug 488
Deleting driver does not delete child policies or publisher and subscriber objects
Last modified: 2011-06-05 07:04:07 UTC
Either the the editor that deletes a driver needs to delete the publisher, subscriber all child policies within the driver, publisher and subscriber or the model must detect the deletion of a driver and perform the associated deletes.
This has been a discussed idea. There are a few cases where removing an object can assume removal of other (i.e. a policy always needs to remove the policy data) ... However, it may be best to just require each remove command (for these cases) removal all related objects for command stack and other issues.
If the editor is to handle deleting child objects or cleaning them up then this is a function of the Modeler and Outline view.
Will's statement seems correct in theory, but I can't come up with a practical case for why you would want to delete a parent (like a Driver) and not have the children (policies and subscriber/publisher channels) go away. This would make no sense; you will certainly have orphaned items in the model that can't possibly function on their own. Our model should provide this level of "garbage collection" or it's going to be quite a chore for our developers - know one is going to intuitively know to do this. I can't understand how a command stack would trump this basic need either. What would a command stack do anyway? Let's say, you're in the Outline View and add a Driver, then a couple of policies. Now, you Delete the Driver and it cleans out the policies in the UI (of course) and the model. The user then wants to undo that operation. They undo it, and the Driver comes back with all of its policies. They undo it again and a policy will disappear. Then undo again, and the other policy goes. Then undo again, the Driver goes. Redo, will be able to re-create things as well. So, I don't see how the command stack somehow negates the need for clean up or how clean up would mess up the command stack. It appears compatible to me. If there are issues, it's not hard to make the command stack logic to implement things.
*** Bug 78124 has been marked as a duplicate of this bug. ***
Too late to take a model change for M4.
I have fixed most of the problems related to this bug inclduing making related objects delete along with parent objects. I am leaving this bug open because we still need to remove "XMLData" objects and that will require one more model change.
Fixed
Because bug number comments have not been added to the subversion comment I have no idea what build this was added in.
Marking closed/resolved fixed bugs public view.